Skip to content

Fix comments attached to array element #7672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jul 21, 2025
Merged

Fix comments attached to array element #7672

merged 8 commits into from
Jul 21, 2025

Conversation

shulhi
Copy link
Member

@shulhi shulhi commented Jul 19, 2025 •
edited
Loading

Fix #7655

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Jul 19, 2025 •
edited
Loading

Open in StackBlitz

rescript

npm i https://pkg.pr.new/rescript-lang/rescript@7672

@rescript/darwin-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-arm64@7672

@rescript/darwin-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-x64@7672

@rescript/linux-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-arm64@7672

@rescript/linux-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-x64@7672

@rescript/win32-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/win32-x64@7672

commit: 8d8ca5a

@shulhi shulhi requested review from cknitt and nojaf July 20, 2025 12:12
nojaf
nojaf reviewed Jul 20, 2025
View reviewed changes
@shulhi shulhi marked this pull request as draft July 20, 2025 12:43
@shulhi shulhi force-pushed the fix/array-comment branch from 138f55f to bbb7b11 Compare July 21, 2025 07:45
@shulhi shulhi marked this pull request as ready for review July 21, 2025 07:47
@shulhi shulhi force-pushed the fix/array-comment branch from bbb7b11 to 8d8ca5a Compare July 21, 2025 07:48
cknitt
cknitt approved these changes Jul 21, 2025
View reviewed changes
Copy link
Member

@cknitt cknitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! 🎉

@shulhi shulhi merged commit dffc266 into rescript-lang:master Jul 21, 2025
27 checks passed
@shulhi shulhi deleted the fix/array-comment branch July 21, 2025 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nojaf nojaf nojaf left review comments

@cknitt cknitt cknitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Formatting array containing array spreads moves comments
3 participants
@shulhi @cknitt @nojaf