Mention which package was not found in the build state.

[nojaf]

In this PR, I want to highlight the problem found in #7688

When inside a monorepo, you need to specify the root folder if the cwd is not that directory.

Running rescript clean ../../.. is the right thing to do for the analysis tests.

This change snowballed a bit, it required more corrections for other packages.
Names need to align in rescript.json and package.json.

I also had some instances where a filename was already in use. (Tuples.res vs nested/Tuples.res). This change seems correct, not sure why this wasn't a problem before.

Lastly, I've added some more text in the ReScript errors so the user knows why things are failing.

[nojaf]

Another problem I see here is that the inheritance part of the rescript.json isn't quite respected in:

rescript/rewatch/src/build/compile.rs

Lines 364 to 396 in c092acd

	let bsc_flags = config::flatten_flags(&config.compiler_flags);
	let dependency_paths = get_dependency_paths(config, project_root, workspace_root, packages, is_type_dev);
	let module_name = helpers::file_path_to_module_name(file_path, &config.get_namespace());
	let namespace_args = match &config.get_namespace() {
	packages::Namespace::NamespaceWithEntry { namespace: _, entry } if &module_name == entry => {
	// if the module is the entry we just want to open the namespace
	vec![
	"-open".to_string(),
	config.get_namespace().to_suffix().unwrap().to_string(),
	]
	}
	packages::Namespace::Namespace(_)
	| packages::Namespace::NamespaceWithEntry {
	namespace: _,
	entry: _,
	} => {
	vec![
	"-bs-ns".to_string(),
	config.get_namespace().to_suffix().unwrap().to_string(),
	]
	}
	packages::Namespace::NoNamespace => vec![],
	};
	let jsx_args = root_config.get_jsx_args();
	let jsx_module_args = root_config.get_jsx_module_args();
	let jsx_mode_args = root_config.get_jsx_mode_args();
	let jsx_preserve_args = root_config.get_jsx_preserve_args();
	let gentype_arg = config.get_gentype_arg();
	let warning_args = config.get_warning_args(is_local_dep);

Root BSC flags won't be picked up.

Jsx args need to come from the root and can't be overridden by the package config.

[nojaf]

Okay, another interesting finding is that running a top-level rescript clean will purge the runtime assets in lib/bs.

So, doing a clean for the test analysis project (with the correct root folder argument) will remove the runtime as well.

[cknitt]

Is it possible to bubble this up as a Result instead?

[nojaf]

To what end, I wonder? This is a configuration error or cli argument error. Feels fine to fail her in my opinion.
We should, of course, communicate why it failed.

[jfrolich]

Another problem I see here is that the inheritance part of the rescript.json isn't quite respected in:

rescript/rewatch/src/build/compile.rs

Lines 364 to 396 in c092acd

	let bsc_flags = config::flatten_flags(&config.compiler_flags);
	let dependency_paths = get_dependency_paths(config, project_root, workspace_root, packages, is_type_dev);
	let module_name = helpers::file_path_to_module_name(file_path, &config.get_namespace());
	let namespace_args = match &config.get_namespace() {
	packages::Namespace::NamespaceWithEntry { namespace: _, entry } if &module_name == entry => {
	// if the module is the entry we just want to open the namespace
	vec![
	"-open".to_string(),
	config.get_namespace().to_suffix().unwrap().to_string(),
	]
	}
	packages::Namespace::Namespace(_)
	| packages::Namespace::NamespaceWithEntry {
	namespace: _,
	entry: _,
	} => {
	vec![
	"-bs-ns".to_string(),
	config.get_namespace().to_suffix().unwrap().to_string(),
	]
	}
	packages::Namespace::NoNamespace => vec![],
	};
	let jsx_args = root_config.get_jsx_args();
	let jsx_module_args = root_config.get_jsx_module_args();
	let jsx_mode_args = root_config.get_jsx_mode_args();
	let jsx_preserve_args = root_config.get_jsx_preserve_args();
	let gentype_arg = config.get_gentype_arg();
	let warning_args = config.get_warning_args(is_local_dep);

Root BSC flags won't be picked up.

Jsx args need to come from the root and can't be overridden by the package config.

BSC flags are from the local config (I think this is correct, this is a package local config because for some packages you want to set specific BSC flags. JSX is already obtained from the root config.

[nojaf]

BSC flags are from the local config (I think this is correct, this is a package local config because for some packages you want to set specific BSC flags. JSX is already obtained from the root config.

I can see scenarios where having a top-level BSC flag applied to all my projects would be beneficial. Manually copying those flags to each project does seem cumbersome.

Regarding JSX, I can also envision a use case where I have a separate package for my React components. In that case, using the "preserve JSX" flag and changing the file extension to JSX for that specific project would be ideal.

So, I'm unsure if those BSC flags and JSX settings should be fixed at a single level. The config inheritance, as I understand it, is certainly more complex to implement correctly.