Enable more ruff rules #6444
Open
Enable more ruff rules #6444
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @KKoukiou - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 3 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| return True | ||
|
|
||
| return False | ||
| return any(source.network_required for source in self.sources) |
There was a problem hiding this comment.
nitpick: Use a generator expression with any() for conciseness and short-circuiting.
| if val: | ||
| return True | ||
| return False | ||
| return any(val for val in kernels.values()) |
There was a problem hiding this comment.
nitpick: Simplify loop using any() for readability.
| @@ -137,7 +137,7 @@ def initialize(self): | |||
|
|
|||
| # Start with the already set locale. Whether kickstart, geolocation, or default - it does | |||
| # not matter, it's resolved and loaded by now. | |||
| locales = [self._l12_module.Language] or [DEFAULT_LANG] | |||
There was a problem hiding this comment.
issue (bug_risk): Fix fallback logic to use DEFAULT_LANG when Language is falsy.
Previously, DEFAULT_LANG was never used due to the always-truthy list. This update ensures proper fallback.
Comment on lines
383
to
+385
| if not conf.ui.show_kernel_options: | ||
| return False | ||
| for val in kernels.values(): | ||
| if val: | ||
| return True | ||
| return False | ||
| return any(val for val in kernels.values()) |
There was a problem hiding this comment.
suggestion (code-quality): We've found these issues:
- Lift code into else after jump in control flow (
reintroduce-else) - Replace if statement with if expression (
assign-if-exp) - Simplify generator expression (
simplify-generator)
Suggested change
| if not conf.ui.show_kernel_options: | |
| return False | |
| for val in kernels.values(): | |
| if val: | |
| return True | |
| return False | |
| return any(val for val in kernels.values()) | |
| return False if not conf.ui.show_kernel_options else any(kernels.values()) |
|
/kickstart-tests --testtype smoke |
This caught a real mistake in the code. In Python, non-empty lists are always truthy. So, this expression always evaluated to [self._l12_module.Language], regardless of what's inside. The intent was, use self._l12_module.Language if it's truthy, otherwise fall back to DEFAULT_LANG. Fix the code to do that.
KKoukiou
force-pushed
the
enable-more-ruff-rules
branch
from
e45d10f to
6279479
Compare
|
/kickstart-tests --testtype smoke |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.