Skip to content

Fix Kotlin nullable string error in RiveReactNativeViewManager #289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix Kotlin nullable string error in RiveReactNativeViewManager #289

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 20 additions & 20 deletions android/src/main/java/com/rivereactnative/RiveReactNativeViewManager.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,9 @@ class RiveReactNativeViewManager : SimpleViewManager<RiveReactNativeView>() {

"play" -> {
args?.let {
val animationName = it.getString(0)
val loopMode = it.getString(1)
val direction = it.getString(2)
val animationName = it.getString(0) ?: ""
val loopMode = it.getString(1) ?:""
val direction = it.getString(2) ?:""
val isStateMachine = it.getBoolean(3)
view.run {
val rnLoopMode = RNLoopMode.mapToRNLoopMode(loopMode)
Expand All @@ -46,8 +46,8 @@ class RiveReactNativeViewManager : SimpleViewManager<RiveReactNativeView>() {

"fireState" -> {
args?.let {
val stateMachineName = it.getString(0)
val inputName = it.getString(1)
val stateMachineName = it.getString(0) ?:""
val inputName = it.getString(1) ?:""
view.run {
fireState(stateMachineName, inputName)
}
Expand All @@ -56,8 +56,8 @@ class RiveReactNativeViewManager : SimpleViewManager<RiveReactNativeView>() {

"setBooleanState" -> {
args?.let {
val stateMachineName = it.getString(0)
val inputName = it.getString(1)
val stateMachineName = it.getString(0) ?:""
val inputName = it.getString(1) ?:""
val value = it.getBoolean(2)
view.run {
setBooleanState(stateMachineName, inputName, value)
Expand All @@ -67,8 +67,8 @@ class RiveReactNativeViewManager : SimpleViewManager<RiveReactNativeView>() {

"setNumberState" -> {
args?.let {
val stateMachineName = it.getString(0)
val inputName = it.getString(1)
val stateMachineName = it.getString(0) ?:""
val inputName = it.getString(1) ?:""
val value = it.getDouble(2)
view.run {
setNumberState(stateMachineName, inputName, value.toFloat())
Expand All @@ -78,8 +78,8 @@ class RiveReactNativeViewManager : SimpleViewManager<RiveReactNativeView>() {

"fireStateAtPath" -> {
args?.let {
val inputName = it.getString(0)
val path = it.getString(1)
val inputName = it.getString(0) ?:""
val path = it.getString(1) ?: ""
view.run {
fireStateAtPath(inputName, path)
}
Expand All @@ -88,9 +88,9 @@ class RiveReactNativeViewManager : SimpleViewManager<RiveReactNativeView>() {

"setBooleanStateAtPath" -> {
args?.let {
val inputName = it.getString(0)
val inputName = it.getString(0) ?:""
val value = it.getBoolean(1)
val path = it.getString(2)
val path = it.getString(2) ?:""
view.run {
setBooleanStateAtPath(inputName, value, path)
}
Expand All @@ -99,9 +99,9 @@ class RiveReactNativeViewManager : SimpleViewManager<RiveReactNativeView>() {

"setNumberStateAtPath" -> {
args?.let {
val inputName = it.getString(0)
val inputName = it.getString(0) ?:""
val value = it.getDouble(1)
val path = it.getString(2)
val path = it.getString(2) ?:""
view.run {
setNumberStateAtPath(inputName, value.toFloat(), path)
}
Expand Down Expand Up @@ -134,8 +134,8 @@ class RiveReactNativeViewManager : SimpleViewManager<RiveReactNativeView>() {

"setTextRunValue" -> {
args?.let {
val textRunName: String = it.getString(0)
val textValue: String = it.getString(1)
val textRunName: String = it.getString(0) ?:""
val textValue: String = it.getString(1) ?:""
view.run {
this.setTextRunValue(textRunName, textValue)
}
Expand All @@ -144,9 +144,9 @@ class RiveReactNativeViewManager : SimpleViewManager<RiveReactNativeView>() {

"setTextRunValueAtPath" -> {
args?.let {
val textRunName: String = it.getString(0)
val textValue: String = it.getString(1)
val path: String = it.getString(2)
val textRunName: String = it.getString(0) ?:""
val textValue: String = it.getString(1) ?:""
val path: String = it.getString(2) ?:""
view.run {
this.setTextRunValueAtPath(textRunName, textValue, path)
}
Expand Down