reading twice a config file that changed would not overwrite old in-memory config #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erwrite the old in-memory config.
|
Thanks for pull request, however I think that we should not break the API compatibility for any bugfix. I am willing to merge this if it is backwards compatible (speaking of making section children a hashmap). |
|
The sections and subsections work the same way as they used to from outside. The only incompatible change is: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a bug where reading twice a config file that changed would not overwrite the old in-memory config.
The previous version would simply append the new version (with the same section name) in the section array and it would be ignored.