-
Notifications
You must be signed in to change notification settings - Fork 7
Making barge align use vision instead of odometry #179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…o SoloController
// various former controls that were previously used and could be referenced in | ||
// the future | ||
|
||
// operatorController |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How likely is this to be used in the future? If it hasn't been used in 6 months, just delete it unless you have a specific clear plan for re-use.
Future coders can always pull it back from git history.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no its for archives
Passing driveBaseWrapper around to all of the routines is fine and aligns with the programming standards the team uses, so fine leave as is. However, assuming there is ever only a single driveBaseWrapper instance at a time, you might consider implementing a Singleton pattern inside of the DriveBaseWrapper class, that way you can get the instance inside of the routines where you need it instead of having to pass it down through the call stacks all over the place. Note that this is a bit more of an advanced coding construct (so totally fine not to do it this way). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved pending comments are addressed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address comments.
move the arm pivot
This reverts commit eba139b.
Test @ field calibration at bordie |
helps address #177