Fuzz fixes #7891
Open
Fuzz fixes #7891
+353
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtfeldman
reviewed
Jun 28, 2025
| // This index doesn't point to a type annotation node - skip it gracefully | ||
| return; | ||
| }, | ||
| } |
There was a problem hiding this comment.
Hrm, this seems suspicious. It seems like if we ever call this function on something that isn't an annotation, that indicates a compiler bug (as opposed to e.g. malformed source code from the end user).
There was a problem hiding this comment.
I think a better way to handle this would be to do a debug assertion, and then if we hit that debug assertion, look at the stack trace to figure out what sequence of events led us to call this function on something that wasn't a type annotation, and apply a fix there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.