Skip to content

Feature alias extra info added #338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 17, 2025
Merged

Feature alias extra info added #338

merged 2 commits into from
Jun 17, 2025

Conversation

Krmjn09
Copy link
Collaborator

@Krmjn09 Krmjn09 commented Jun 17, 2025

No description provided.

@Krmjn09 Krmjn09 changed the base branch from master to dev June 17, 2025 11:32
@Krmjn09 Krmjn09 requested review from linev and silverweed June 17, 2025 11:34
silverweed
silverweed approved these changes Jun 17, 2025
View reviewed changes
Copy link
Contributor

@silverweed silverweed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine at a first glance. We would need to add tests with files that use alias columns and extra type info, but let's do it later to get sooner to deserializing the data.

Please fix the eslint warnings before merging

@Krmjn09
Copy link
Collaborator Author

Krmjn09 commented Jun 17, 2025

@linev, please merge this pr #338 . It passed all checks and with this the deserialization of header is completed

@linev linev merged commit d34d684 into root-project:dev Jun 17, 2025
24 checks passed
@Krmjn09 Krmjn09 deleted the feature-alias-extra-info branch June 18, 2025 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silverweed silverweed silverweed approved these changes

@linev linev Awaiting requested review from linev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Krmjn09 @silverweed @linev