-
Notifications
You must be signed in to change notification settings - Fork 80
Added Logic for footer Deserialisation #339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Logic for footer Deserialisation #339
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! The numbers are correct. I left a couple of comments: you can tackle them here or in a future PR, as you prefer
|
||
|
||
// Schema extension record frame (4 list frames inside) | ||
this._readFieldDescriptors(reader); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The schema extension reading can later be refactored into a separate function since it's the same code as the header (same with the code to read the frames).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok 👍
There are many eslint warnings all around; I'm guessing you haven't set up eslint so that it automatically fixes your formatting (I assume this is possible, you should not have to manually fix all these warnings). Maybe ask @linev for help to set it up and run it on your code before committing your changes for the future. |
You always can use And right now I add to repository |
No description provided.