Skip to content

Added Logic for footer Deserialisation #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 18, 2025

Conversation

Krmjn09
Copy link
Collaborator

@Krmjn09 Krmjn09 commented Jun 18, 2025

No description provided.

@Krmjn09 Krmjn09 requested review from silverweed and linev June 18, 2025 05:48
@Krmjn09
Copy link
Collaborator Author

Krmjn09 commented Jun 18, 2025

image
This is the output i am getting for footer deserialisation , please check

@Krmjn09 Krmjn09 changed the base branch from master to dev June 18, 2025 06:02
Copy link
Contributor

@silverweed silverweed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! The numbers are correct. I left a couple of comments: you can tackle them here or in a future PR, as you prefer



// Schema extension record frame (4 list frames inside)
this._readFieldDescriptors(reader);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The schema extension reading can later be refactored into a separate function since it's the same code as the header (same with the code to read the frames).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok 👍

@silverweed
Copy link
Contributor

silverweed commented Jun 18, 2025

There are many eslint warnings all around; I'm guessing you haven't set up eslint so that it automatically fixes your formatting (I assume this is possible, you should not have to manually fix all these warnings). Maybe ask @linev for help to set it up and run it on your code before committing your changes for the future.

@linev
Copy link
Member

linev commented Jun 18, 2025

You always can use npm run check command to see problems with the current code.
I typically adjust code by hand to fix warnings.

And right now I add to repository npm run fix command which automatically fix problems which can be fixed by eslint.
You can later use it as well.

@silverweed silverweed merged commit ae3a7d2 into root-project:dev Jun 18, 2025
24 checks passed
@Krmjn09 Krmjn09 deleted the feature/footer-deserialisation branch June 18, 2025 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants