Using the enumeration code #351
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Krmjn09
requested review from
silverweed and
linev
and removed request for
silverweed
silverweed
requested changes
Jul 17, 2025
| // Determine byte size per value based on column type | ||
| function getTypeByteSize(coltype) { | ||
| switch (coltype) { | ||
| case ENTupleColumnType.kReal64: |
There was a problem hiding this comment.
I'm not sure this function can be very helpful later because some types have a size that's not an integer number of bits (e.g. Bit is 1 bit in size, Real32Trunc and Real32Quant have a variable bit length, etc).
For now it's fine to keep, but keep that in mind.
modules/rntuple.mjs
Outdated
| kByte: 4, | ||
| kChar: 5, | ||
| kBit: 6, | ||
| kReal64: 13, |
There was a problem hiding this comment.
Please write these numbers in hexadecimal so they are more easily comparable with the BinarySpecification and the C++ version
silverweed
approved these changes
Jul 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.