-
Notifications
You must be signed in to change notification settings - Fork 80
Feature/removed hardcoded column handling #352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/removed hardcoded column handling #352
Conversation
modules/rntuple.mjs
Outdated
for (let i = 0; i < numEntries; ++i) { | ||
const obj = {}; | ||
for (const [fieldName, values] of Object.entries(rntuple._clusterData)) | ||
obj[fieldName] = values[i]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason to use an intermediate obj
rather than directly selector.tgtobj
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yess i could have directly assign the value to selector.tgtobj
I will change this as soon as possible!
Thankyou for pointing out!
Please review @silverweed
You requested a new review but it looks like there are no changes from my latest review: did you forget to push something? |
I posted replies to your comments so that is why I requested a review on my answers Maybe just mentioning can help |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Have you tested that the Selector test still works properly?
Yes @silverweed |
I was thinking to try this code after creating some other simple root files and test on them |
No description provided.