-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[io] read versioned class from file even if in-memory-class is unversioned #18660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ferdymercury
wants to merge
11
commits into
root-project:master
Choose a base branch
from
ferdymercury:unvers
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
27bec90
[io] read versioned class from file even if in-memory-class is unvers…
ferdymercury d77fdff
[io] add test for unversioned reading
ferdymercury 0c11f3d
[test] fix compilation errors
ferdymercury 996bd60
[test] fix missing semicolon
ferdymercury 244b902
[test] fix paths
ferdymercury 064c343
[test] move from gtest to roottest
ferdymercury 4b7f2aa
[io] allow also ClassDef0
ferdymercury 75e7355
[io] undo change
ferdymercury 0d97984
[test] newline
ferdymercury d9e9023
[test] try to fix test failure when moved from gtest to roottest
ferdymercury 1aada00
[test] delete
ferdymercury File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
#include "TInterpreter.h" | ||
#include "TFile.h" | ||
|
||
#ifndef SUBCLASS_HH | ||
#define SUBCLASS_HH | ||
class MySubClass | ||
{ | ||
public: | ||
int id; | ||
}; | ||
#endif | ||
#ifdef __ROOTCLING__ | ||
#pragma link C++ class MySubClass+; | ||
#endif | ||
|
||
// https://its.cern.ch/jira/browse/ROOT-5306 | ||
int execROOT5306() | ||
{ | ||
// Original file was generated as: | ||
// .L MySubClass.cxx+ | ||
// TFile f("/tmp/mysub.root", "RECREATE"); | ||
// MySubClass msc; | ||
// msc.id = 33; | ||
// f.WriteObjectAny(&msc, "MySubClass", "msc"); | ||
// f.Close(); | ||
// with MySubClass.cxx containing: class MySubClass { public: int id; ClassDef(MySubClass, 3) }; | ||
TFile f("mysub.root", "READ"); | ||
auto msc = f.Get<MySubClass>("msc"); | ||
if (msc->id != 33) { | ||
printf("Error: id is %d vs 33\n", msc->id); | ||
return 3; | ||
} | ||
return 0; | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
|
||
Processing execROOT5306.cxx+... | ||
(int) 0 |
Binary file not shown.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.