-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[ntuple][RFC] Do type-check in RValue::GetRef with basic data types #18719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Test Results 19 files 19 suites 3d 18h 32m 36s ⏱️ For more details on these failures, see this check. Results for commit d186288. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to go through RField<T>
for the type name check, like RField<T>::TypeName() == fField->GetTypeName()
. This will still not solve the case when the fField
pointer is already gone at the time we call GetRef()
. While we could store the full type name string in RValue
, that would be costly and I'd like to avoid it.
I think this issue needs more thought and discussion.
This Pull request:
Changes or fixes:
Fixes #18316
Checklist: