[roottest] dismiss RootExeOptions and RootExternalIncludes cmake variables
#19086
+113
−253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is more clear to provide root.exe options in ROOTTEST_ADD_TEST macro
Use (void)gSystem->Load(\"libbase\") to exclude extra printout Configure fixture instead of dependency
pcanal
reviewed
Jun 18, 2025
pcanal
reviewed
Jun 18, 2025
pcanal
reviewed
Jun 18, 2025
pcanal
reviewed
Jun 18, 2025
pcanal
reviewed
Jun 18, 2025
pcanal
reviewed
Jun 18, 2025
Test Results 20 files 20 suites 3d 21h 50m 52s ⏱️ For more details on these failures, see this check. Results for commit 618747b. ♻️ This comment has been updated with latest results. |
Use (void) to suppress output when loading libs Remove unused ref file
Allows to configure fixture
Adjust ref files while in many tests libEvent library loading not required and therefore extra output caused by loading not created
Use ROOTTEST_ADD_TEST to create and copy hsimple.root files One can set fixtures and correctly organize dependencies Copy ROOT files for runtreeCloneTest2.C directly, let run test on Windows - where PRECMD may lead to test disabling Use fixtures for dependnecies
It replaced by ARG_ROOTEXE_OPTS, which can be configured individual for each test
Instead using RootExternalIncludes variable one can just use ROOTEXE_OPTS which does the same
No need for special variable only for includes Build library with ROOTTEST_GENERATE_DICTIONARY Configure dependency with fixtures
Replaced by ROOTEXE_OPTS argument which is individual for each test and does not interfere with other tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both variables adding custom arguments to
root.exeinvocation in the roottest macros.Main disadvantage of such variables - all consequent tests will use such variables -
which was not necessary in several cases, especially in
root/tree/cloningtests.All this can be replaced by
ROOTEXE_OPTSargument ofROOTTEST_ADD_TESTmacro.It assigned per-test and therefore more precise.
In the tests where such options were replaced also fix dependencies using fixtures -
which is more reliable than use of
DEPENDSarguments.