Speed up test compilation when Ninja is in use #19128
Open
+0
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Roottest tests were compiled sequentially when Ninja was in use, to avoid a problem (the commit doesn't mention details). Since that was 8 years ago, we should give parallel Ninja another try.
hageboeck
force-pushed
the
roottest_slow_ninja
branch
from
36f878e to
7f214a8
Compare
Test Results 20 files 20 suites 4d 3h 33m 34s ⏱️ Results for commit 7f214a8. |
dpiparo
approved these changes
Jun 23, 2025
|
That is a good idea. We need to 1) Add ninja to one of the container images 2) build with ninja for that platform - this can be one of the experimental builds (clang? nomodules? marchnative?) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Difference on my machine (8 physical cores) running
ctest -R meta -j16:Note:
I tested this locally on Gentoo, but our CI is kind of blind to running with Ninja. Maybe it's worth to take one of the distros and make it compile with Ninja?