Read correct size of TClonesArray collection value type #19140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vepadulano
requested review from
bellenot,
martamaja10 and
pcanal
as code owners
|
Thanks! |
RDataFrame uses the information of `GetValueSize` methods to understand the size of a collection value type, for those TTree branches that have to be read via TTreeReaderArray. These include input TClonesArray branches, for which the size of the collection value type was wrongly computed. In fact, it is not enough to just ask the TClonesArray what is the size of the class type it is wrapping, since the reader (RDataFrame) may be wanting to read only a data member of that class. The correct information is stored in the TBranchProxy, which knows exactly which branch (or leaf) RDataFrame is trying to read. Thus, use the `GetValueSize` method of the proxy directly.
Test Results 20 files 20 suites 4d 3h 35m 17s ⏱️ Results for commit d03c84f. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19104