[v636] Backport fixes #19158
Merged
[v636] Backport fixes #19158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now we don't support the newest TensorFlow releases after the 2.15 series, initially released in November 2023 [1]. Support for TensorFlow>=2.16 is worked on [2], but it's difficult to make progress if we don't have TensorFlow>=2.16 in our CI images. And we veto it from our CI image via the `requirements.txt` mechanism. To continue, we need to temporarily disable PyMVA in the CI, such that we can include the newest TensorFlow version in our images, and then re-enable it in the PR that fixes support for the newest TensorFlow. This is what is done in this commit. Supporting the newest TensorFlow became a bit more important now that we also have another feature besides PyMVA that uses TensorFlow: the RBatchGenerator. It would not good to hold off testing the actively-developed RBatchGenerator on newer TensorFlow versions, just because PyMVA prevents us from installing these on our CI. [1] https://github.com/tensorflow/tensorflow/releases [2] root-project#15790
Correctly append the additional RPATHs set by the ROOT build system to the `CMAKE_INSTALL_RPATH` variable set by the user, which is cached in `CMAKE_INSTALL_RPATH-CACHED` by the ROOT build system. Follows up on c77bd87. Closes root-project#19134. Needs a backport to 6.36.
guitargeek
requested review from
bellenot,
dpiparo and
vepadulano
as code owners
guitargeek
merged commit 95ab3c5
into
root-project:v6-36-00-patches
19 of 22 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport fixes to the current release branch.