[Python][UHI] Remove __eq__ Pythonization for TH1 Derived Classes #19209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
guitargeek
approved these changes
Jun 27, 2025
Test Results 20 files 20 suites 3d 15h 11m 42s ⏱️ Results for commit 8a5b97c. |
dpiparo
approved these changes
Jun 27, 2025
vepadulano
approved these changes
Jun 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull request:
Changes or fixes:
This PR removes the
__eq__operator pythonization for TH1 and its derived classes, which was introduced as part of the UHI implementation. The operator caused unintended backward-incompatible behavior and potential confusion for python users. Instead of extending the operator to address concerns raised in #19061, this PR reverts it entirely.Checklist:
This PR fixes #19038