Skip to content

[tree] allow skipping longdoubles when building tree index #19561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 13, 2025

Conversation

ferdymercury
Copy link
Collaborator

@ferdymercury ferdymercury commented Aug 7, 2025

This Pull request:

Changes or fixes:

Fixes #19560

Checklist:

  • tested changes locally
  • updated the docs (if necessary)

@ferdymercury ferdymercury marked this pull request as ready for review August 7, 2025 08:07
@couet couet assigned couet and pcanal and unassigned couet Aug 7, 2025
Copy link

github-actions bot commented Aug 7, 2025

Test Results

    21 files      21 suites   3d 8h 49m 7s ⏱️
 3 363 tests  3 349 ✅ 0 💤 14 ❌
68 900 runs  68 886 ✅ 0 💤 14 ❌

For more details on these failures, see this check.

Results for commit aff1543.

♻️ This comment has been updated with latest results.

@ferdymercury ferdymercury requested a review from pcanal August 12, 2025 06:14
@amete
Copy link

amete commented Aug 12, 2025

Thanks a lot for the PR @ferdymercury. Once this converges, could we please backport the fix to both versions 6.32 and 6.36?

Copy link
Member

@pcanal pcanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@dpiparo dpiparo merged commit 63ef302 into root-project:master Aug 13, 2025
21 of 26 checks passed
@ferdymercury ferdymercury deleted the intindex branch August 13, 2025 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TTreeIndex fails under Valgrind due to long double emulation
5 participants