[TestSupport] Remove a special case for RNTuple. #19563
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that RNT is not experimental, TestSupport doesn't need to mask its warning messages.
Test Results 21 files 21 suites 3d 8h 49m 10s ⏱️ For more details on these failures, see this check. Results for commit 6fa1f9b. |
|
Actually merging RNTuples is still experimental so I believe this should remain until the RNTupleMerger is out of Experimental |
Initially, I thought to replace it by "active" checking, but seeing the number of warnings in the files, I tend to agree. 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that RNT is not experimental, TestSupport doesn't need to mask its warning messages when running gtest.
The remaining warning message about merging can be masked explicitly (which is already happening in ntuple_merger.cxx).