Skip to content

[math] properly check for symmetry when constructing TSym #19570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 11, 2025

Conversation

ferdymercury
Copy link
Collaborator

Fixes #19568

@ferdymercury ferdymercury requested a review from lmoneta as a code owner August 7, 2025 12:56
Copy link

github-actions bot commented Aug 7, 2025

Test Results

    21 files      21 suites   3d 16h 32m 31s ⏱️
 3 250 tests  3 246 ✅ 0 💤 4 ❌
66 528 runs  66 524 ✅ 0 💤 4 ❌

For more details on these failures, see this check.

Results for commit eb0fdd0.

♻️ This comment has been updated with latest results.

@dpiparo dpiparo requested a review from hageboeck August 9, 2025 12:20
@hageboeck hageboeck self-assigned this Aug 11, 2025
Copy link
Member

@hageboeck hageboeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! Thanks @ferdymercury!

@hageboeck
Copy link
Member

The fedora failures are unrelated, and I don't see a good reason to clang-format the surrounding code, so I'll merge as is.

@hageboeck hageboeck merged commit b6fb6bd into root-project:master Aug 11, 2025
43 of 48 checks passed
@ferdymercury ferdymercury deleted the patch-20 branch August 11, 2025 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ineffective TMatrixTSym symmetry check during construction
2 participants