Skip to content

[roottest] improve cmake for root/collection #19571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

linev
Copy link
Member

@linev linev commented Aug 7, 2025

Use explicit list of tests - one test was not present in automatic list
Copy ROOT file only for specific test
Remove unnecessary .rootrc

Use explicit list of test - one test was not present in automatic list
Copy ROOT file only for specific test
@linev linev self-assigned this Aug 7, 2025
@linev linev requested review from bellenot and dpiparo as code owners August 7, 2025 13:00
@linev linev removed the request for review from dpiparo August 7, 2025 13:02
@bellenot bellenot requested a review from pcanal August 7, 2025 13:57
Copy link
Member

@bellenot bellenot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar enough with these tests. Let's ask @pcanal what he thinks about this PR

@linev
Copy link
Member Author

linev commented Aug 7, 2025

I do not change tests - just adding fixtures to have clear order of tests invocation.
DEPENDS argument of ROOTTEST_ADD_TEST does not invoke required test

Copy link

github-actions bot commented Aug 7, 2025

Test Results

    21 files      21 suites   3d 12h 37m 31s ⏱️
 3 251 tests  3 247 ✅ 0 💤 4 ❌
66 549 runs  66 545 ✅ 0 💤 4 ❌

For more details on these failures, see this check.

Results for commit 8302d18.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants