[core] Move TClass tests to core/meta

core/clingutils/res/TClingUtils.h

@@ -12,8 +12,6 @@
 #ifndef ROOT_TMetaUtils
 #define ROOT_TMetaUtils
 
-#include "RConversionRuleParser.h"
-
 #include <functional>
 #include <set>
 #include <string>

core/clingutils/src/TClingUtils.cxx

@@ -25,6 +25,7 @@
 #include <cctype>
 
 #include "RConfigure.h"
+#include "RConversionRuleParser.h"
 #include <ROOT/RConfig.hxx>
 #include <ROOT/FoundationUtils.hxx>
 #include "Rtypes.h"

core/clingutils/test/CMakeLists.txt

@@ -30,4 +30,4 @@ if(NOT builtin_clang)
   link_directories("${LLVM_LIBRARY_DIR}")
 endif()
 
-ROOT_ADD_UNITTEST_DIR(Core RIO ${CLING_LIBRARIES} $<TARGET_OBJECTS:ClingUtils>)
+ROOT_ADD_UNITTEST_DIR(Core ${CLING_LIBRARIES} $<TARGET_OBJECTS:ClingUtils>)

core/clingutils/test/TClingUtilsTests.cxx

@@ -15,15 +15,18 @@
  *************************************************************************/
 
 #include <TClingUtils.h>
-#include <TClass.h>
-#include <TInterpreter.h>
 
+// This test must under no circumstances include other ROOT headers. It must not call into Cling, TInterpreter, TClass.
+// It is meant for unit testing of TClingUtils and statically links ClingUtils and Cling/Clang/LLVM libraries. If the
+// test was to do any of the above, there would be two copies of functions around (in libCling.so and the test binary)
+// with not much guarantees which ones are called at which moment.
+
+#include <DllImport.h>
 #include <ROOT/FoundationUtils.hxx>
 
 #include "gtest/gtest.h"
 
 #include <fstream>
-#include <deque>
 
 TEST(TClingUtilsTests, GetCppName)
 {
@@ -89,24 +92,12 @@ TEST(TClingUtilsTests, GetRealPath)
 #endif // not R__WIN32
 }
 
-TEST(TClingUtilsTests, CollectionSizeof)
-{
-   // https://its.cern.ch/jira/browse/ROOT-9889
-   EXPECT_EQ(sizeof(std::deque<short>), TClass::GetClass("std::deque<short>")->GetClassSize());
-   EXPECT_EQ(sizeof(std::deque<unsigned short>), TClass::GetClass("std::deque<unsigned short>")->GetClassSize());
-   EXPECT_EQ(sizeof(std::deque<int>), TClass::GetClass("std::deque<int>")->GetClassSize());
-   EXPECT_EQ(sizeof(std::deque<unsigned int>), TClass::GetClass("std::deque<unsigned int>")->GetClassSize());
-   EXPECT_EQ(sizeof(std::deque<long>), TClass::GetClass("std::deque<long>")->GetClassSize());
-   EXPECT_EQ(sizeof(std::deque<unsigned long>), TClass::GetClass("std::deque<unsigned long>")->GetClassSize());
-}
+// Forward-declare gCling to not include TInterpreter.h just for checking that the interpreter has not been initialized.
+class TInterpreter;
+R__EXTERN TInterpreter *gCling;
 
-TEST(TClingUtilsTests, ReSubstTemplateArg)
-{
-   // #18811
-   gInterpreter->Declare("template <typename T> struct S {};"
-                         "template <typename T1, typename T2> struct Two { using value_type = S<T2>; };"
-                         "template <typename T> struct One { Two<int, int>::value_type *t; };");
+class InterpreterCheck : public testing::Environment {
+   void TearDown() override { ASSERT_EQ(gCling, nullptr); }
+};
 
-   auto c = TClass::GetClass("One<std::string>");
-   c->BuildRealData();
-}
+testing::Environment *gInterpreterCheck = testing::AddGlobalTestEnvironment(new InterpreterCheck);

core/dictgen/src/XMLReader.cxx

@@ -18,6 +18,7 @@
 
 
 #include "XMLReader.h"
+#include "RConversionRuleParser.h"
 #include "SelectionRules.h"
 #include "TClingUtils.h"
 

core/dictgen/src/rootcling_impl.cxx

@@ -12,6 +12,7 @@
 #include "rootclingCommandLineOptionsHelp.h"
 
 #include "RConfigure.h"
+#include "RConversionRuleParser.h"
 #include <ROOT/RConfig.hxx>
 #include <ROOT/FoundationUtils.hxx>
 #include "snprintf.h"

core/meta/test/testTClass.cxx

@@ -7,6 +7,8 @@
 
 #include "gtest/gtest.h"
 
+#include <deque>
+
 TEST(TClass, DictCheck)
 {
    gInterpreter->ProcessLine(".L stlDictCheck.h+");
@@ -80,3 +82,25 @@ TEST(TClass, ConsistentSTLLookup)
    auto second = first->GetActualClass(&map);
    EXPECT_EQ(first, second);
 }
+
+TEST(TClass, CollectionSizeof)
+{
+   // https://its.cern.ch/jira/browse/ROOT-9889
+   EXPECT_EQ(sizeof(std::deque<short>), TClass::GetClass("std::deque<short>")->GetClassSize());
+   EXPECT_EQ(sizeof(std::deque<unsigned short>), TClass::GetClass("std::deque<unsigned short>")->GetClassSize());
+   EXPECT_EQ(sizeof(std::deque<int>), TClass::GetClass("std::deque<int>")->GetClassSize());
+   EXPECT_EQ(sizeof(std::deque<unsigned int>), TClass::GetClass("std::deque<unsigned int>")->GetClassSize());
+   EXPECT_EQ(sizeof(std::deque<long>), TClass::GetClass("std::deque<long>")->GetClassSize());
+   EXPECT_EQ(sizeof(std::deque<unsigned long>), TClass::GetClass("std::deque<unsigned long>")->GetClassSize());
+}
+
+TEST(TClass, ReSubstTemplateArg)
+{
+   // #18811
+   gInterpreter->Declare("template <typename T> struct S {};"
+                         "template <typename T1, typename T2> struct Two { using value_type = S<T2>; };"
+                         "template <typename T> struct One { Two<int, int>::value_type *t; };");
+
+   auto c = TClass::GetClass("One<std::string>");
+   c->BuildRealData();
+}

core/metacling/src/TClingCallbacks.cxx

@@ -11,6 +11,7 @@
 
 #include "TClingCallbacks.h"
 
+#include <DllImport.h> // for R__EXTERN
 #include <ROOT/FoundationUtils.hxx>
 
 #include "cling/Interpreter/DynamicLibraryManager.h"