-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[rootest] improve cmake of root/meta
tests
#19589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
linev
wants to merge
27
commits into
root-project:master
Choose a base branch
from
linev:roottest_meta
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2865872
to
fce8afe
Compare
Test Results 21 files 21 suites 3d 11h 12m 18s ⏱️ For more details on these failures, see this check. Results for commit 05b483c. ♻️ This comment has been updated with latest results. |
Use fixture and explicit tests creation By this reactivate ROOT-5759 test
First generate all dicitonaries Provide runscript.C macro which executes line by line existing scripts from scripts/ sub-directory Minimally adjust ref files
Introduce fixtures Always provide output for genreflex to avoid creation of temporary files in source directory
Remove old Makefile, .rootrc file and configure fixtures
It is generation of reflex dictionary for huge PyCool project Check only if dictionary generated and compiled into static library Remove lot of unused files
Configure missing stltest2.ref file Remove unused teststl.ref Provide separate windows ref files for foreign test
Add clear dependency via fixtures
4aa69ff
to
b96181b
Compare
Like in cmsUnload, provide special runscript.C which loads commands and invoke them one by one.
Remove usedBits.C macro while it uses no longer exists TClass interface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
meta/genreflex/ROOT-5768
into cmake, delete unused files there