Skip to content

Fix handling for CONST properties in CreateOpticalSurfaceN method #19593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 12, 2025

Conversation

KoljaFrahm
Copy link
Contributor

@KoljaFrahm KoljaFrahm commented Aug 9, 2025

This Pull request:

Changes or fixes:

Checklist:

  • tested changes locally
  • updated the docs (if necessary)

This PR fixes #19592

@KoljaFrahm KoljaFrahm requested a review from agheata as a code owner August 9, 2025 15:55
@KoljaFrahm
Copy link
Contributor Author

Fixes #19592

@dpiparo
Copy link
Member

dpiparo commented Aug 9, 2025

Running the CI waiting the expert review of @agheata .

Copy link

github-actions bot commented Aug 9, 2025

Test Results

    21 files      21 suites   3d 7h 2m 51s ⏱️
 3 250 tests  3 247 ✅ 0 💤 3 ❌
66 486 runs  66 479 ✅ 0 💤 7 ❌

For more details on these failures, see this check.

Results for commit c3a1ba7.

Copy link
Member

@agheata agheata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @KoljaFrahm for spotting this!

@dpiparo dpiparo merged commit b3c0617 into root-project:master Aug 12, 2025
21 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No Constant Properties exported for Optical surfaces
3 participants