Skip to content

[cling] Provide C value printer, adopted from Ruben De Smet! #9272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

[cling] Provide C value printer, adopted from Ruben De Smet! #9272

wants to merge 3 commits into from

Conversation

Axel-Naumann
Copy link
Member

@Axel-Naumann Axel-Naumann commented Nov 11, 2021 •
edited by ferdymercury
Loading

@Axel-Naumann Axel-Naumann self-assigned this Nov 11, 2021
@phsft-bot
Copy link

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu2004/soversion, mac1015/python3, mac11.6/cxx17, windows10/cxx14
How to customize builds

@Axel-Naumann Axel-Naumann mentioned this pull request Nov 11, 2021
Open
@Axel-Naumann
Copy link
Member Author

Axel-Naumann commented Nov 11, 2021 •
edited by ferdymercury
Loading

Fixes root-project/cling#364
Fixes root-project/cling#419
and helps for jupyter-xeus/xeus-cling#404

vgvassilev
vgvassilev approved these changes Nov 11, 2021
View reviewed changes
Copy link
Member

@vgvassilev vgvassilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add tests.

@ferdymercury ferdymercury assigned dpiparo and unassigned Axel-Naumann Apr 12, 2024
@Axel-Naumann Axel-Naumann requested a review from dpiparo as a code owner April 13, 2024 10:46
@ferdymercury ferdymercury requested a review from vgvassilev April 13, 2024 10:47
@ferdymercury
[cling] fix c print test
9e915d8 
missing data type return
vgvassilev
vgvassilev approved these changes Apr 13, 2024
View reviewed changes
Copy link
Member

@vgvassilev vgvassilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ferdymercury
Copy link
Collaborator

LGTM!

Thanks! By the way I have no idea how the cling-tests worked, so I just tried to copy what I saw in the lines above with the comment doing the "CHECK" I hope.

@github-actions GitHub Actions
Copy link

Test Results

    11 files      11 suites   2d 3h 36m 20s ⏱️
 2 609 tests  2 609 ✅ 0 💤 0 ❌
26 878 runs  26 878 ✅ 0 💤 0 ❌

Results for commit 9e915d8.

@vgvassilev
Copy link
Member

vgvassilev commented Apr 13, 2024 •
edited by ferdymercury
Loading

LGTM!

Thanks! By the way I have no idea how the cling-tests worked, so I just tried to copy what I saw in the lines above with the comment doing the "CHECK" I hope.

The easiest way would be to configure ROOT with -Dclingtest=On -Dtesting=On and run it within ctest.

@ferdymercury ferdymercury mentioned this pull request Apr 14, 2024
Open
@ferdymercury
Copy link
Collaborator

run it within ctest.

I get the following result when running ctest clingtest-check-cling, but I see no sign that the test under question is being run?

clingtest.txt

@vgvassilev
Copy link
Member

run it within ctest.

I get the following result when running ctest clingtest-check-cling, but I see no sign that the test under question is being run?

clingtest.txt

Is it in the source tree under interpreter/cling/test?

@ferdymercury
Copy link
Collaborator

run it within ctest.

I get the following result when running ctest clingtest-check-cling, but I see no sign that the test under question is being run?
clingtest.txt

Is it in the source tree under interpreter/cling/test?

Yes, and then Driver/C.c

@vgvassilev
Copy link
Member

Should have ran. If you want to make sure just introduce an error in the test and see if it starts to fail.

@ferdymercury ferdymercury marked this pull request as draft April 17, 2024 08:53
@ferdymercury ferdymercury mentioned this pull request Jan 14, 2025
Open
@ferdymercury
Copy link
Collaborator

Rebased/moved to #17422

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vgvassilev vgvassilev vgvassilev approved these changes

@dpiparo dpiparo Awaiting requested review from dpiparo dpiparo is a code owner

Assignees

@dpiparo dpiparo

Labels
in:Cling
Projects
None yet
Milestone
No milestone
5 participants
@Axel-Naumann @phsft-bot @ferdymercury @vgvassilev @dpiparo