int object has no attribute strip #52
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alejandro Hernandez Cordero <[email protected]>
Signed-off-by: Alejandro Hernandez Cordero <[email protected]>
130s
reviewed
Sep 4, 2025
There was a problem hiding this comment.
Not very familiar with this codebase so my comments are rather just comments.
Curious to see test result. Looks like there's a test that calls the very function that is being changed, generate_dotcode.
Then, IIUC, the test is NOT executed on CI (a result from this PR)? If so better run the test on CI.
| @@ -95,6 +95,14 @@ def generate_dotcode(self, | |||
| self.listen_duration = 0 | |||
|
|
|||
| yaml_data = tf2_frame_srv.call(FrameGraph.Request()).frame_yaml | |||
|
|
|||
| def my_construct_mapping(self, node, deep=False): | |||
| data = self.construct_mapping_org(node, deep) | |||
There was a problem hiding this comment.
Does self.construct_mapping_org reference properly? I can't find the definition of such a symbol.
| data = self.construct_mapping_org(node, deep) | ||
| return {(str(key) if isinstance(key, int) else key): data[key] for key in data} | ||
|
|
||
| yaml.SafeLoader.construct_mapping_org = yaml.SafeLoader.construct_mapping |
There was a problem hiding this comment.
Is there a usecase for yaml.SafeLoader.construct_mapping_org?
Co-authored-by: Isaac Saito <[email protected]>
Co-authored-by: Isaac Saito <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related with #27