-
Notifications
You must be signed in to change notification settings - Fork 141
Improvements for the URDF xsd specification #200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: harleylara <[email protected]>
Signed-off-by: harleylara <[email protected]>
Signed-off-by: Amin Yahyaabadi <[email protected]>
Signed-off-by: Amin Yahyaabadi <[email protected]>
Signed-off-by: Amin Yahyaabadi <[email protected]>
Signed-off-by: Amin Yahyaabadi <[email protected]>
This pull request has been mentioned on ROS Discourse. There might be relevant details there: |
Hi people 😃 ... any update on this ? |
The PR has been ready to get merged! Waiting for someone with access. |
Good point. @mjcarroll It does not seem that there are a lot of active maintainers in URDF-related repos (typically because existing one are busy). Would you be open to add some maintainers to the maintenance team? |
I would be up for discussing it. This repo is maintained by the ROS 2 PMC, so issues here should be serviced with relative frequency. I will bring it up in the meeting next week, at a minimum as a friendly reminder that we should be maintaining this as well. |
Thanks a lot! |
Shouldn't this PR be retargeted to traversaro:movespecification, because it is basically an extension of it? |
The purpose here is improving the specification while the other PR's main goal was to move the files. |
Pulls: #200 |
Pulls: #200 |
CI looks good, but I don't personally have permissions to merge this. |
The improvements include specifications for:
This builds on top of the XSD changes from #183 and then fixes the remaining XSD issues related to:
The specification can be tested via the following (e.g. in VsCode with the XML extension):
The above code is backward compatible with the parsers as it doesn't add a namespace to the robot tag. If a namespace is added, some parsers like Python's parser add
ns0:
before the tags. Not requiring a namespace makes it possible to verify the XML without changing the tags.