Improve global variable alias error messaging #3610
Draft
+4
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve error message for invalid global variable aliasing
Summary
This PR improves the error message when attempting to alias a global variable with a non-global variable. The previous generic error message was misleading and has been replaced with a more specific and descriptive one.
The Problem
The old error message was confusing because it didn't explain the actual constraint. Consider this example:
This error message is misleading because:
b
is a bare word, which the error says is expectedThe Solution
The new error message clearly states the actual requirement:
Changes
PM_ERR_ALIAS_ARGUMENT_GLOBAL_VARIABLE
to provide clearer error messagingaliasing_global_variable_with_non_global_variable.txt
to verify the new error message