Skip to content

Conversation

@atzoum
Copy link
Contributor

@atzoum atzoum commented Oct 24, 2025

🔒 Scanned for secrets using gitleaks 8.28.0

Description

WIP

router 101-Router throughput drawio (2)

Linear Ticket

resolves PIPE-2500

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@atzoum atzoum force-pushed the feat.dynamicRtWorkerBuffer branch 3 times, most recently from e1be1dd to 8204640 Compare October 24, 2025 10:19
@codecov
Copy link

codecov bot commented Oct 24, 2025

Codecov Report

❌ Patch coverage is 97.66082% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.29%. Comparing base (bf55861) to head (bfa6256).

Files with missing lines Patch % Lines
router/worker_batch_loop.go 60.00% 1 Missing and 1 partial ⚠️
router/worker_buffer.go 96.15% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6463      +/-   ##
==========================================
+ Coverage   79.27%   79.29%   +0.01%     
==========================================
  Files         529      530       +1     
  Lines       59350    59492     +142     
==========================================
+ Hits        47048    47172     +124     
- Misses       9492     9501       +9     
- Partials     2810     2819       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@atzoum atzoum force-pushed the feat.dynamicRtWorkerBuffer branch 3 times, most recently from 364cfb5 to cbd3e0d Compare October 24, 2025 14:52
🔒 Scanned for secrets using gitleaks 8.28.0
@atzoum atzoum force-pushed the feat.dynamicRtWorkerBuffer branch from cbd3e0d to bfa6256 Compare October 24, 2025 15:07
doProcessRouterJobs() // process any remaining jobs in the batch
return // input channel is closed, exit the loop
}
if wl.ctx.Err() != nil {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: this is to allow router to stop faster and not hinder graceful shutdowns or workspace partition migrations

🔒 Scanned for secrets using gitleaks 8.28.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant