Add Gielinor Gains plugin with build fix #8906
Conversation
cameronspears
commented
Aug 26, 2025
cameronspears
commented
- Fix dependency verification metadata for CI build
- Update to commit fa813ea192a015da3a076698003daaa2f8af415a
- Fix dependency verification metadata for CI build - Update to commit fa813ea192a015da3a076698003daaa2f8af415a
|
New plugin |
- Update to commit 71b1aaa7977e91ff10845b3a73c5be9f970bd0f0 - Fix dependency verification by adding trusted-artifacts configuration
- Update to commit 72233b9c8ac8c028fbc9608e4d2fcd49e55d9d80 - Use compileOnly for OkHttp and Gson (provided by RuneLite) - Removes dependency verification errors
- Update to commit 4fd5e3b517bf13f905c57d117bb662e32931460c - Completely removed OkHttp and Gson dependencies - Plugin uses RuneLite client's built-in HTTP/JSON capabilities - Should eliminate all dependency verification errors
- Update to commit 46118dfe3d58c7d76fe7d8420ff28ae323803e60 - Plugin now properly injects RuneLite's OkHttpClient and Gson instances - Uses .newBuilder() to customize instead of creating new instances - Should eliminate terminal API deprecation warnings
|
This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed. Internal use only: Reviewer details Maintainer details |
- Update to commit 206afdee32cd6d3887357932c720fc7ad54fdbf8 - Fix oversized logo-white.png (reduced by ~94%) - Should pass Plugin Hub size validation
Updates to commit 17d3ab0d1fa0503ece588b80497f5fd7e1c3a1d3 which includes icon scaling optimization using nearest-neighbor interpolation for crisp pixel art rendering. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
|
Not a complete review, but:
|
tylerwgrass
added
the
waiting for author
Great points. Let me handle those. |
runelite-github-app
bot
removed
the
waiting for author
|
@tylerwgrass your feedback has been resolved. |
|
3 days to review is a long time. Anything we can do to speed this up? |
|
Reviewers are all volunteers who have jobs and do things when they have the time to do so. You just need to be patient. |
There was a problem hiding this comment.
You'll have to add a warning= to your runelite-plugin.propertiesplugin/gielinor-gains file due to your plugin connecting to an external service not controlled by RuneLite. This warning must include that their IP is being sent, and should also detail what else you're intending to send. See this message from one of the RuneLite admins: https://discord.com/channels/301497432909414422/419891709883973642/1409410895783657492
Anywhere you use ImageIO.read, you should wrap that in a synchronize block, e.g.:
BufferedImage image;
synchronized (ImageIO.class) {
image = ImageIO.read(url);
}
// use imageNot a requirement, but anywhere you use new Timer you can usually instead use an injected ScheduledExecutorService.
The code looks non-malicious, but I haven't carefully looked into how strings returned from the API are used.
aHooder
added
the
waiting for author
runelite-github-app
bot
removed
the
waiting for author
|
The warning needs to go in your plugin hub manifest file, not the |
pajlada
added
the
waiting for author
🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
runelite-github-app
bot
removed
the
waiting for author
No problem. Got it updated! |
|
Am I missing something? Is there a change requested of me that I missed? Edit: I think its just the UI being a little confusing. |
|
No you just need to wait. Your plugin is using certain features which require more scrutinous review from a maintainer |
Thanks. I'm patient (for the most part), just wanted to make sure I wasn't forgetting something. The UI says Changes Requested, so that made me wonder. All good. |
