Skip to content

Conversation

bielie993-ui
Copy link

@bielie993-ui bielie993-ui commented Aug 26, 2025

Alch Teleport Block

A simple plugin which blocks teleports in your regular spellbook to prevent accidental teleports while alching. The block can be overruled by pressing a modifier key. If the user wants it to only be activated if an alch was cast x seconds ago thats also possible, to make it more dynamic.


Features

  • Choose from all regular spellbook teleports (default: Kourend Castle, Falador).
  • Enable a "block window" which only adds the modifier for x seconds after alching.
    • Detects high and low alchs.
    • Change block duration (default is 30s).
  • Change the modifier key (default is CTRL).
  • Right click casting is still instant (can be disabled in config).
image
image

@runelite-github-app
Copy link

runelite-github-app bot commented Aug 26, 2025

aHooder
aHooder previously approved these changes Aug 26, 2025
Copy link
Contributor

@aHooder aHooder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neither of these are blockers, but:

  • Right-click teleporting to Seers' ignores the delay since the option doesn't include the string "cast", which kinda goes against the "allow right-click casting" option:
    image
  • This may interact a little bit strangely with shift-click remapping on teleport spells.

For other reviewers, runelite-plugin.properties is parsed with https://docs.oracle.com/javase/8/docs/api/java/util/Properties.html#load-java.io.Reader- so the empty line is okay.

@aHooder aHooder dismissed their stale review August 26, 2025 17:50

Nvm, apparently the icon size needs to be smaller.

Copy link
Contributor

@aHooder aHooder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You must reduce your icon file size to below 256 KiB. While you're at it, perhaps you want to address some of the above-mentioned issues also?

@bielie993-ui
Copy link
Author

bielie993-ui commented Aug 26, 2025

Neither of these are blockers, but:

  • Right-click teleporting to Seers' ignores the delay since the option doesn't include the string "cast", which kinda goes against the "allow right-click casting" option:
    image
  • This may interact a little bit strangely with shift-click remapping on teleport spells.

For other reviewers, runelite-plugin.properties is parsed with https://docs.oracle.com/javase/8/docs/api/java/util/Properties.html#load-java.io.Reader- so the empty line is okay.

Good catch, ill change that, i also need to add the Grand Exchange and Yanille i noticed.

Updated version
@bielie993-ui
Copy link
Author

Added the missing teleports and improved the detection of them. Reduced icon size. Should be all good.

@aHooder Not sure what the failed pipeline means? Any tips?

@bielie993-ui bielie993-ui requested a review from aHooder August 26, 2025 20:13
@aHooder
Copy link
Contributor

aHooder commented Aug 26, 2025

It just needed confirmation before running the checks, probably because your github user is relatively new.

@aHooder
Copy link
Contributor

aHooder commented Aug 26, 2025

It looks like you've accidentally replaced your icon.png file with an empty file.

@aHooder aHooder added the waiting for author waiting for the pr author to make changes or respond to questions label Aug 26, 2025
@runelite-github-app runelite-github-app bot removed the waiting for author waiting for the pr author to make changes or respond to questions label Aug 26, 2025
@bielie993-ui
Copy link
Author

It looks like you've accidentally replaced your icon.png file with an empty file.

Hmm if i open it on my desktop it opens just fine. But when i check git it gives a source error. If you open the file it actually works though:

https://github.com/bielie993-ui/runelite-alch-tp-blocker/blob/47369287731f3f982bd1a3533021fca788e41733/icon.png

@runelite-github-app
Copy link

runelite-github-app bot commented Aug 26, 2025

This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed.


Internal use only: Reviewer details Maintainer details

aHooder
aHooder previously approved these changes Aug 26, 2025
Copy link
Contributor

@aHooder aHooder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me now, but you'll have to wait for a maintainer to review your plugin before it can be merged.

@bielie993-ui
Copy link
Author

This looks good to me now, but you'll have to wait for a maintainer to review your plugin before it can be merged.

Sorry for the hassle, but had to remove the repo and recreate it. I pushed with the wrong user and didnt want those details to be visible.

Copy link
Contributor

@aHooder aHooder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but you'll have to wait for a maintainer to review.

@bielie993-ui
Copy link
Author

Going to work on the same idea, but the plugin will have a different name.

@aHooder
Copy link
Contributor

aHooder commented Aug 29, 2025

You should've perhaps mentioned that you wanted to expand the idea to be a more general purpose accidental teleport blocker, rather than one centered around alching 👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants