-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Add Block Teleport While Alching plugin #8909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
New plugin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neither of these are blockers, but:
- Right-click teleporting to Seers' ignores the delay since the option doesn't include the string "cast", which kinda goes against the "allow right-click casting" option:
- This may interact a little bit strangely with shift-click remapping on teleport spells.
For other reviewers, runelite-plugin.properties
is parsed with https://docs.oracle.com/javase/8/docs/api/java/util/Properties.html#load-java.io.Reader- so the empty line is okay.
Nvm, apparently the icon size needs to be smaller.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You must reduce your icon file size to below 256 KiB. While you're at it, perhaps you want to address some of the above-mentioned issues also?
Good catch, ill change that, i also need to add the Grand Exchange and Yanille i noticed. |
Updated version
Added the missing teleports and improved the detection of them. Reduced icon size. Should be all good. @aHooder Not sure what the failed pipeline means? Any tips? |
It just needed confirmation before running the checks, probably because your github user is relatively new. |
It looks like you've accidentally replaced your |
Hmm if i open it on my desktop it opens just fine. But when i check git it gives a source error. If you open the file it actually works though: |
This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed. Internal use only: Reviewer details Maintainer details |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me now, but you'll have to wait for a maintainer to review your plugin before it can be merged.
Sorry for the hassle, but had to remove the repo and recreate it. I pushed with the wrong user and didnt want those details to be visible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but you'll have to wait for a maintainer to review.
Going to work on the same idea, but the plugin will have a different name. |
You should've perhaps mentioned that you wanted to expand the idea to be a more general purpose accidental teleport blocker, rather than one centered around alching 👀 |
Alch Teleport Block
A simple plugin which blocks teleports in your regular spellbook to prevent accidental teleports while alching. The block can be overruled by pressing a modifier key. If the user wants it to only be activated if an alch was cast x seconds ago thats also possible, to make it more dynamic.
Features