Implement settxfee method and test #285
Conversation
| () => { | ||
| impl Client { | ||
| pub fn set_tx_fee(&self, fee_rate: bitcoin::FeeRate) -> Result<SetTxFee> { | ||
| let fee_rate_btc_kvb = fee_rate.to_sat_per_vb_floor() as f64 / 100_000.0; |
There was a problem hiding this comment.
This is correct and drinks on me because you found an API hole in rust-bitcoin. See rust-bitcoin/rust-bitcoin#4688 if you are interested.
There was a problem hiding this comment.
Woaw, interesting, reading through the issue and conversations.
There was a problem hiding this comment.
Interestingly copilot picked this out as an issue with the PR: although mathematically correct, it says "rust-bitcoin does not provide a safe, explicit conversion between FeeRate and the units expected by Core's settxfee". It managed to actually look at the referenced issue and give a sane answer. It has improved even in the last 6 months. Still can't trust it though 😊.
There was a problem hiding this comment.
Mad, keep me posted of any AI wins please. I"m a bit of a ludite and I don't want to fall too far behind.
There was a problem hiding this comment.
Interestingly copilot picked this out as an issue with the PR: although mathematically correct, it says "rust-bitcoin does not provide a safe, explicit conversion between FeeRate and the units expected by Core's
settxfee". It managed to actually look at the referenced issue and give a sane answer. It has improved even in the last 6 months. Still can't trust it though 😊.
Woah, that’s cool. They’ve definitely come a long way...
Improve test expect message
|
rebased and worked on the suggestion given. |
| () => { | ||
| impl Client { | ||
| pub fn set_tx_fee(&self, fee_rate: bitcoin::FeeRate) -> Result<SetTxFee> { | ||
| let fee_rate_btc_kvb = fee_rate.to_sat_per_vb_floor() as f64 / 100_000.0; |
There was a problem hiding this comment.
Interestingly copilot picked this out as an issue with the PR: although mathematically correct, it says "rust-bitcoin does not provide a safe, explicit conversion between FeeRate and the units expected by Core's settxfee". It managed to actually look at the referenced issue and give a sane answer. It has improved even in the last 6 months. Still can't trust it though 😊.
The JSON-RPC method
settxfeedoes return a type. We want to test this to catch any changes in behavior in future Core versions.This PR adds a client function that errors if the return value is anything other than the type it returns, along with an integration test that calls this function.
Ref: #116