Skip to content

Add addmultisigaddress test and update structs #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 14, 2025
Merged

Add addmultisigaddress test and update structs #329

merged 2 commits into from
Aug 14, 2025
+231 −114

Conversation

jamillambert
Copy link
Collaborator

addaddressmultisig is untested and missing return fields added in versions after v17.

  • Add a test and update the struct for changes in v20 and v23, update the model, into_model() reexports and types table.
  • Fun the formatter.

@jamillambert
Fix addmultisigaddress
fc00cab 
Add a test and update the struct for changes in v21 and v23.
Update the types table and reexports.
@jamillambert
Run the formatter
f89352c
tcharding
tcharding approved these changes Aug 14, 2025
View reviewed changes
Copy link
Member

@tcharding tcharding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK f89352c

@tcharding tcharding merged commit ad4d7b9 into rust-bitcoin:master Aug 14, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcharding tcharding tcharding approved these changes

Assignees
No one assigned
Labels
C-integration-test C-types
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamillambert @tcharding