Test listaddressgroupings
#330
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`listaddressgroupings` was untested. Add a test for it that returns a non emply list. When Serde deserializes from a JSON array (a sequence), it uses positional fields and requires the sequence length to match the number of struct fields exactly. This causes an error when the optional field `label` is not returned. Change the struct to an enum with 2 fields, one for 2 returned items and one for 3.
jamillambert
force-pushed
the
0813-listaddressgroupings
branch
from
8436521 to
e76ab0d
Compare
tcharding
approved these changes
Aug 14, 2025
|
Nice, you worked out the JSON shape, that stumped me. |
Yeah it was a strange one. I assumed it would work like the others and using an Option would take care of the field being there or not. I had no idea Serde worked like that with a JSON array. AI first tried to write this massive deserialization function just for that one case, and I had to argue with it for a bit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
listaddressgroupingswas untested.Add a test for it that returns a non empty list. But now with this test there is an error because "when Serde deserializes from a JSON array (a sequence), it uses positional fields and requires the sequence length to match the number of struct fields exactly" (AI quote). Which causes an error when the optional field
labelis not returned.Change the struct to an enum with 2 fields, one for 2 returned items and one for 3.
No changes to the RPC return fields up to v29.