ci: delete broken wasm job #840
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
apoelstra
changed the title
Rust 1.88.0 introduced a warning, and 1.89.0 made it an error, to dereference a raw pointer in a way where it is implicitly turned into a reference. This is probably a good lint but breaking compilation like this is bullshit. There are many instances of this in our fuzz code (none in the real code). We just need to change the implicit & and &muts to explicit ones. We will need to backport some change if we want our CI to keep working on old versions. Probably just whitelisting the lint for old versions of the library is fine.
Incorrect indentation causes Github to report "syntax error on line 1" and silently disable all of the checks in this library. For example, see https://github.com/apoelstra/rust-secp256k1/actions/runs/17178718613/workflow After fixing the indentation, the test doesn't work, obviously, because it's a wasm test.
apoelstra
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The incorrectly-indented wasm test from #819 is causing Github to silently disable all of our checks. If you click through to the "Actions" tab of this repo you can see it failing (with a "syntax error on line 1" nonsense error). For example https://github.com/apoelstra/rust-secp256k1/actions/runs/17178718613/workflow
Delete the test, and also fix everything else that broke in the meantime.