-
Notifications
You must be signed in to change notification settings - Fork 31
USB HID support #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
USB HID support #57
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Could you have a look at the conflicts?
Yeah, just needs a rebase. |
Added a test case using reports captured from my actual keyboard - works as expected. Also added a CHANGELOG entry. |
Force pushed with fixed formatting |
It appears USB HID keyboards don't send repeated reports when a key is held down - unlike PS/2 keyboards. Therefore we'll need some way of submitting a 'blank' report, which causes every key currently pressed to get emitted again. But you'll want to time that right because if the timer fires immediately after a key is pressed, you'll get a double character that you don't want. Maybe we'll end up needing a HashMap of Or just not worry about it. On a modern macOS machine, it doesn't even do repeated characters when a key is held - it pops up an accented character picker instead. |
Interesting. Do you want to do more changes about that here or should this be merged as-is? |
Oh this is fine as-is. Typematic repeats can be a separate thing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Adds a USB Keyboard type which can handle USB HID frames from a Keyboard in Boot Mode.
Builds on #52 so merge that first.