Fix indentation of static path restriction text #1961
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
In the const eval chapter, we have a list of kinds of expressions that are allowed. Paths to statics are one kind that is allowed, but have certain restrictions we describe in bullet points. We then have text that clarifies when these bullet points are checked. This text was outdented beyond the relevant item, which broke up the outer bullet point list and created (momentary) ambiguity about the scope of the rules the language might be affecting. Let's fix that.
traviscross
force-pushed
the
TC/fix-indentation-of-static-path-restriction
branch
from
1e45abf to
378fa89
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the const eval chapter, we have a list of kinds of expressions that are allowed. Paths to statics are one kind that is allowed, but have certain restrictions we describe in bullet points. We then have text that clarifies when these bullet points are checked.
This text was outdented beyond the relevant item, which broke up the outer bullet point list and created (momentary) ambiguity about the scope of the rules the language might be affecting.
cc @ehuss