FIX: NegMultiply should preserve parenthesis when method is called #15179
+63
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I noticed that the lint neg_multiply generates bad code when we call a method on the expression.
Consider
((a.delta - 0.5).abs() * -1.0).total_cmp(&1.0)
. Currently this would be changed by clippy to-(a.delta - 0.5).abs() .total_cmp(&1.0)
- which does not compile because we are trying to negate an ordering enum - but what we really want is(-(a.delta - 0.5).abs()).total_cmp(&1.0)
.This PR fixes this.
changelog: [
neg_multiply
] does not remove parenthesis anymore if a method is being called on the affected expressionNOTE: This is the first time I am contributing to clippy or the rust repo in general. So I am not sure whether my approach to fixing this issue is goo, if there are better solutions or if I missed something.
Thanks & hope you have a good day,
Dario