Skip to content

Remove CSS bootstrap dependency #15251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

GuillaumeGomez
Copy link
Member

@GuillaumeGomez GuillaumeGomez commented Jul 11, 2025

Follow-up of #15208.

This PR removes the CSS bootstrap dependency which contains 1504 CSS rules and weights 16.1 kB minified. Considering we used less than 50 of these rules, it's quite a waste.

So this time, there are minor UI changes:

  • The "expand/collapse all" buttons icon changed. It now uses the one from font-awesome. It's quite close but not exactly the same.
  • The layout is slightly different (you need to switch between two tabs to actually see the difference).

Before this PR:

image

With this PR:

image

With this, we will be able to go even further on reducing the page size next. =D

This time, the DOM size itself reduced a bit but the difference is too small to be noteworthy.

r? @samueltardieu

changelog: Remove CSS bootstrap dependency

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jul 11, 2025
@samueltardieu
Copy link
Contributor

Since this is user-facing, I'll let @flip1995 weight in here.
r? @flip1995

@rustbot rustbot assigned flip1995 and unassigned samueltardieu Jul 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants