Skip to content

Generate lint count in template #15414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 5, 2025

Conversation

Alexendoo
Copy link
Member

Removes the pop-in of the element on page load

changelog: none

@rustbot
Copy link
Collaborator

rustbot commented Aug 5, 2025

r? @blyxyas

rustbot has assigned @blyxyas.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 5, 2025
Copy link
Member

@samueltardieu samueltardieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r? samueltardieu

@@ -49,7 +49,7 @@
<script src="theme.js"></script> {# #}

<div class="container"> {# #}
<h1 class="page-header">Clippy Lints <span id="lint-count" class="badge"></span></h1> {# #}
<h1 class="page-header">Clippy Lints <span class="badge">Total number: {{ count }}</span></h1> {# #}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The space between ":" and the lint count seem to not be preserved when rendering.

Suggested change
<h1 class="page-header">Clippy Lints <span class="badge">Total number: {{ count }}</span></h1> {# #}
<h1 class="page-header">Clippy Lints <span class="badge">Total number:&nbsp;{{ count }}</span></h1> {# #}

@rustbot rustbot assigned samueltardieu and unassigned blyxyas Aug 5, 2025
@samueltardieu samueltardieu added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Aug 5, 2025
@Alexendoo Alexendoo force-pushed the lint-count-template branch from 61b4c19 to 0ea413f Compare August 5, 2025 11:40
@samueltardieu samueltardieu added this pull request to the merge queue Aug 5, 2025
Merged via the queue into rust-lang:master with commit b98252f Aug 5, 2025
8 checks passed
@Alexendoo Alexendoo deleted the lint-count-template branch August 5, 2025 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants