Skip to content

Fix unnecessary_sort_by lint method consistency in message and suggestion #15416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Huterenok
Copy link
Contributor

The unnecessary_sort_by lint displays different method names in message and suggestion, which is a bit confusing.

Also got a question about UNNECESSARY_SORT_BY lint definition. Should we extend its message to also cover unstable methods?

changelog: [unnecessary-sort-by]: sort method consistency in message and suggestion

@rustbot
Copy link
Collaborator

rustbot commented Aug 5, 2025

r? @dswij

rustbot has assigned @dswij.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 5, 2025
@samueltardieu
Copy link
Member

Thanks for fixing the discrepancies in the error message.

Also got a question about UNNECESSARY_SORT_BY lint definition. Should we extend its message to also cover unstable methods?

It would be a good idea, but as this would be a new feature it would probably not be considered until after the feature freeze period.

@samueltardieu samueltardieu added this pull request to the merge queue Aug 5, 2025
Merged via the queue into rust-lang:master with commit 8396d73 Aug 5, 2025
11 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants