Add the iter_last_slice lint
#15496
Open
Add the iter_last_slice lint
#15496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
|
No changes for 8ea1451 |
rustbot
added
S-blocked
scrabsha
force-pushed
the
push-qtnomsxmmtwq
branch
from
c59a6eb to
9ec4984
Compare
This lint triggers when calling `.iter().last()` on a slice or array and suggests using `.last()` directly. This is a modified version of the `iter_next_slice`. I could not figure out how to avoid code duplication though :/.
scrabsha
force-pushed
the
push-qtnomsxmmtwq
branch
from
9ec4984 to
8ea1451
Compare
ada4a
reviewed
Aug 15, 2025
| iter_overeager_cloned::Op::LaterCloned, | ||
| false, | ||
| ); | ||
| double_ended_iterator_last::check(cx, expr, recv, call_span); |
There was a problem hiding this comment.
Why repeat this check in two match arms? I think leaving it outside the match is fine..
|
|
||
| let _ = s.iter().last(); | ||
| //~^ iter_last_slice | ||
| // Should be replaced by s.last() |
There was a problem hiding this comment.
I think these comments could be left out -- the .fixed file already captures the intended output
| cx, | ||
| ITER_LAST_SLICE, | ||
| expr.span, | ||
| "using `.iter().last()` on a slice without end index", |
There was a problem hiding this comment.
Suggested change
| "using `.iter().last()` on a slice without end index", | |
| "using `.iter().last()` on a slice without start index", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15487.
This lint triggers when calling
.iter().last()on a slice or array and suggests using.last()directly.This is a modified version of the
iter_next_slice. I could not figure out how to avoid code duplication though :/.changelog: Add
iter_last_slicelintSummary Notes
Managed by
@rustbot—see help for details