Skip to content

Fix read_zero_byte_vec suggests wrongly inside let stmt #15582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix read_zero_byte_vec suggests wrongly inside let stmt #15582

wants to merge 1 commit into from
+109 −10

Conversation

profetia
Copy link
Contributor

@profetia profetia commented Aug 27, 2025 •
edited by rustbot
Loading

Closes #15575

changelog: [read_zero_byte_vec] fix wrong suggestions inside let stmt

@rustbot
Copy link
Collaborator

rustbot commented Aug 27, 2025

r? @blyxyas

rustbot has assigned @blyxyas.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 27, 2025
dswij
dswij reviewed Sep 3, 2025
View reviewed changes
Copy link
Member

@dswij dswij left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, definitely a much needed improvement.

View changes since this review

@profetia profetia requested a review from dswij September 3, 2025 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dswij dswij Awaiting requested review from dswij

Assignees

@blyxyas blyxyas

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

read-zero-byte-vec if we assign to a var, post suggestion turns the assignment into () bc of the .resize call
4 participants
@profetia @rustbot @dswij @blyxyas