Explicit ways for triagers to determine contributor activity and advise avoid pinging inactive/on-leave contributors #878
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
jieyouxu
force-pushed
the
pr-triage-advice
branch
from
29cf892 to
3bbca8e
Compare
And advice avoid pinging inactive/on-leave contributors.
jieyouxu
force-pushed
the
pr-triage-advice
branch
from
3bbca8e to
d4d346a
Compare
lolbinarycat
reviewed
Jul 6, 2025
Comment on lines
+66
to
+70
| - Check if contributor is in alumni status. If a contributor is alumni status, they | ||
| should be considered inactive. This can be checked by searching [rust-lang/team]. | ||
| You can use a GitHub search query like | ||
| `repo:rust-lang/team path:/teams/ {GITHUB_HANDLE}` (with `GITHUB_HANDLE` being | ||
| the contributor). |
There was a problem hiding this comment.
Maybe worth noting that we never ping people on T-* teams either, since they'll also get that info from this search?
There was a problem hiding this comment.
Can you elaborate what you mean by
never ping people on
T-*teams?
There was a problem hiding this comment.
I believe we have a guideline to not ping authors if they are on a team, and the instructions don't say anything about pinging reviewers as far as i can see.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussed in #t-release/triage > Please don't ping contributors on leave.
r? @Dylan-DPC
Rendered