Migrate run-make/link-arg to rmake.rs
#126120
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-testsuite
|
Some changes occurred in run-make tests. cc @jieyouxu |
Kobzol
reviewed
Jun 8, 2024
| use run_make_support::{rustc, tmp_dir}; | ||
|
|
||
| fn main() { | ||
| let out = rustc() |
There was a problem hiding this comment.
With the new run-make API, this would looks like this:
let out = rustc()
.link_arg("-lfoo")
.link_arg("-lbar")
.print("link-args")
.input("empty.rs")
.run();
out.assert_stdout_contains("lfoo");
out.assert_stdout_contains("lbar");assert_stdout_containsshould be added here.
|
Oh, there is actually a PR for this already (#125500). We should update the tracking issue faster, too many PRs 😆 |
|
Sorry again, I keep forgetting to update the tracking issue. I need to remember when reviewing rmake.rs PRs to:
And not just "review the PR" lol. |
Hehe, it was bound to happen eventually, these are being produced in industrial quantities. |
|
Ah indeed, closing then! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #121876.
r? @jieyouxu