-
Notifications
You must be signed in to change notification settings - Fork 13.5k
Apply impl_super_outlives
optimization to new trait solver
#142746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Apply impl_super_outlives
optimization to new trait solver
#142746
Conversation
Just for funsies @bors2 try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
Apply `impl_super_outlives` optimization to new trait solver I never did #128746 for the new solver. r? lcnr
This comment has been minimized.
This comment has been minimized.
Finished benchmarking commit (06b3d3c): comparison URL. Overall result: ❌✅ regressions and improvements - please read the text belowBenchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf. Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @bors rollup=never Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary 1.4%, secondary 0.6%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary 2.4%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 691.904s -> 690.865s (-0.15%) |
🤷 still worth I think. I think the coercions perf changes are not related. |
I never did #128746 for the new solver.
r? lcnr