Rollup of 11 pull requests #142781

Kobzol · 2025-06-20T12:59:23Z

Successful merges:

install docs for each target in different directory #142478 (install docs for each target in different directory)
Add config builder for bootstrap tests #142629 (Add config builder for bootstrap tests)
correct template for #[align] attribute #142715 (correct template for #[align] attribute)
De-dup common code from ExternalCrate methods #142720 (De-dup common code from ExternalCrate methods)
add issue template for rustdoc #142736 (add issue template for rustdoc)
rustc-dev-guide subtree update #142743 (rustc-dev-guide subtree update)
Add a mailmap entry for y21 #142744 (Add a mailmap entry for y21)
Make sure to rebuild rustdoc if src/rustdoc-json-types is changed #142758 (Make sure to rebuild rustdoc if src/rustdoc-json-types is changed)
Convert ilog(10) to ilog10() #142764 (Convert ilog(10) to ilog10())
Some symbol and PathRoot cleanups #142767 (Some symbol and PathRoot cleanups)
remove equivalent new method on context #142769 (remove equivalent new method on context)

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

Signed-off-by: xizheyin <[email protected]>

…e-case use consistent title capitalization

Adjust some doc for Query System

content has moved to another chapter

use sentence case

Query cleaning

Use stage 1 for building docs

Also replaced '→' symbol with '->' for consistency across the table.

Remove hanging parenthesis from example signature.

Profiling with perf: specify the section of bootstrap settings.

Document Ambig vs Unambig Type/Consts

That was intended to be a list. Also, the order is not relevant.

fix markup

initial instructions for gpu offload

…anup, r=GuillaumeGomez De-dup common code from `ExternalCrate` methods Also, return an `impl Iterator` instead of collecting into a `Vec`. Not sure if that'll have a measurable perf impact, but I think this PR still cleans up the two methods it touches quite nicely. (I'm having trouble finding a name for the common method I extracted, currently called `foobar`, would love suggestions!)

…e, r=GuillaumeGomez,fmease add issue template for rustdoc ~~This also expands the scope of the "diagnostic issue" template to include rustdoc lints, meaning diagnostic issues will need triaging again. I think this is preferable to the alternative of cramming even more cases under a single issue template.~~ r? t-rustdoc

rustc-dev-guide subtree update r? `@ghost`

Add a mailmap entry for y21

Make sure to rebuild rustdoc if `src/rustdoc-json-types` is changed I think `rustdoc-json-types` was more recently split out, so this download-rustc logic became outdated as it wasn't tracked. This PR adds `src/rustdoc-json-types` to be tracked for difference versus upstream, so that we properly rebuild rustdoc if it has changes versus upstream. Fixes rust-lang#142738. ### Local testing This is not so easy to test locally because it requires download-rustc. To test this, you need to: 1. Disable `download-rustc` inhibition from bootstrap changes versus upstream, by including `:!src/bootstrap` in https://github.com/rust-lang/rust/blob/255aa220821c05c3eac7605fce4ea1c9ab2cbdb4/src/bootstrap/src/core/config/config.rs#L67-L74. 2. Then, use a config like `profile = "tools"` which by default uses `download-rustc = "if-unchanged"`. 3. Run `./x test tests/rustdoc-json` one time, to "prime" initial build caches. 4. Change the `FORMAT_VERSION` in `src/rustdoc-json-types`, i.e. ```diff diff --git a/src/rustdoc-json-types/lib.rs b/src/rustdoc-json-types/lib.rs index 1f93895..72a3720c7b4 100644 --- a/src/rustdoc-json-types/lib.rs +++ b/src/rustdoc-json-types/lib.rs `@@` -38,7 +38,7 `@@` // are deliberately not in a doc comment, because they need not be in public docs.) // // Latest feature: Pretty printing of inline attributes changed -pub const FORMAT_VERSION: u32 = 48; +pub const FORMAT_VERSION: u32 = 666; ``` 5. Observe that without this patch, `rustdoc-json` tests fail because `FORMAT_VERSION` mismatch. Observe that with this patch, rustdoc gets properly rebuilt and `rustdoc-json` tests pass. cc `@aDotInTheVoid` r? Kobzol

…ingjubilee Convert `ilog(10)` to `ilog10()` Except in tests, convert `integer.ilog(10)` to `integer.ilog10()` for better speed and to provide better examples of code that efficiently counts decimal digits. I couldn't find any instances of `integer.ilog(2)`.

…rochenkov Some symbol and PathRoot cleanups I'm looking into unifying how we join and print paths. Here are some preliminary cleanups. r? `@petrochenkov`

…thod, r=tgross35 remove equivalent new method on context Noticed the two had converged so much they literally became equivalent. So one could go hehe

Kobzol · 2025-06-20T12:59:30Z

@bors r+ rollup=never p=5

bors · 2025-06-20T12:59:33Z

📌 Commit 7cb6acc has been approved by Kobzol

It is now in the queue for this repository.

bors · 2025-06-20T15:59:24Z

⌛ Testing commit 7cb6acc with merge f0dec36...

Rollup of 11 pull requests Successful merges: - #142478 (install docs for each target in different directory) - #142629 (Add config builder for bootstrap tests) - #142715 (correct template for `#[align]` attribute) - #142720 (De-dup common code from `ExternalCrate` methods) - #142736 (add issue template for rustdoc) - #142743 (rustc-dev-guide subtree update) - #142744 (Add a mailmap entry for y21) - #142758 (Make sure to rebuild rustdoc if `src/rustdoc-json-types` is changed) - #142764 (Convert `ilog(10)` to `ilog10()`) - #142767 (Some symbol and PathRoot cleanups) - #142769 (remove equivalent new method on context) r? `@ghost` `@rustbot` modify labels: rollup

rust-log-analyzer · 2025-06-20T18:00:02Z

The job dist-i686-msvc failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

Dist rust-nightly-i686-pc-windows-msvc
 finished in 240.551 seconds

thread 'main' panicked at src\bootstrap\src\lib.rs:1847:25:
could not read dir "D:\\a\\rust\\rust\\build\\tmp\\tarball\\rust\\i686-pc-windows-msvc\\rust-docs-nightly-i686-pc-windows-msvc\\rust-docs": Os { code: 3, kind: NotFound, message: "The system cannot find the path specified." }
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
Build completed unsuccessfully in 1:52:14
  local time: Fri Jun 20 17:59:48 CUT 2025
  network time: Fri, 20 Jun 2025 17:59:49 GMT
##[error]Process completed with exit code 1.

bors · 2025-06-20T18:00:32Z

💔 Test failed - checks-actions

tshepang and others added 30 commits June 2, 2025 12:35

use consistent title capitalization

9aa572d

Adjust some doc for Query System

a4c8ef9

Signed-off-by: xizheyin <[email protected]>

install docs for each target in different directory

067a99b

Merge pull request rust-lang#2441 from rust-lang/tshepang-remove-titl…

94d56d1

…e-case use consistent title capitalization

Merge pull request rust-lang#2465 from xizheyin/rustc-query

9265493

Adjust some doc for Query System

content has moved to another chapter

a70deb6

Merge pull request rust-lang#2466 from rust-lang/tshepang-moved

9926215

content has moved to another chapter

use sentence case

0834e48

Merge pull request rust-lang#2467 from rust-lang/tshepang-patch-1

a3f261c

use sentence case

title case

820e88a

do not inline links

21a1e51

Merge pull request rust-lang#2468 from rust-lang/query-cleaning

d16e1a1

Query cleaning

Use stage 1 for building docs

808d16c

Merge pull request rust-lang#2471 from Darksonn/patch-1

3edb332

Use stage 1 for building docs

Remove hanging parenthesis from example signature.

1dbf86a

Also replaced '→' symbol with '->' for consistency across the table.

Merge pull request rust-lang#2472 from cbloodsworth/fix/tytable_parens

02334e1

Remove hanging parenthesis from example signature.

Profiling with perf: specify the section of bootstrap settings.

8bc55da

Merge pull request rust-lang#2475 from lolbinarycat/patch-3

671817f

Profiling with perf: specify the section of bootstrap settings.

Stub chapter and consolidate under /hir/

d96b2d4

Write chapter on Unambig vs Ambig Types/Consts

42888bb

Add links

c1506c0

Reviews

39e9800

Merge pull request rust-lang#2474 from BoxyUwU/ambig_unambig_ty_consts

6c7830e

Document Ambig vs Unambig Type/Consts

fix markup

4145596

That was intended to be a list. Also, the order is not relevant.

Merge pull request rust-lang#2476 from rust-lang/tshepang-patch-1

79652d9

fix markup

initial instructions for gpu offload

0a185e4

Merge pull request rust-lang#2447 from rust-lang/offload-docs

f25cfe8

initial instructions for gpu offload

Preparing for merge from rustc

48b36ee

Merge from rustc

d854d56

Add get_host_target function

8c28161

Kobzol added 8 commits June 20, 2025 14:59

Rollup merge of rust-lang#142743 - tshepang:rdg-push, r=jieyouxu

3a676cc

rustc-dev-guide subtree update r? `@ghost`

Rollup merge of rust-lang#142744 - tgross35:y21-mailmap, r=y21

509d289

Add a mailmap entry for y21

Rollup merge of rust-lang#142767 - nnethercote:symbol-cleanups, r=pet…

4c899b2

…rochenkov Some symbol and PathRoot cleanups I'm looking into unifying how we join and print paths. Here are some preliminary cleanups. r? `@petrochenkov`

Rollup merge of rust-lang#142769 - jdonszelmann:remove-useless-new-me…

7cb6acc

…thod, r=tgross35 remove equivalent new method on context Noticed the two had converged so much they literally became equivalent. So one could go hehe

rustbot added the rollup A PR which is a rollup label Jun 20, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 20, 2025

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 20, 2025

Kobzol mentioned this pull request Jun 20, 2025

install docs for each target in different directory #142478

Open

Kobzol closed this Jun 20, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 11 pull requests #142781

Rollup of 11 pull requests #142781

Kobzol commented Jun 20, 2025 •

edited by rustbot

Loading

Uh oh!

Kobzol commented Jun 20, 2025

Uh oh!

bors commented Jun 20, 2025

Uh oh!

bors commented Jun 20, 2025

Uh oh!

rust-log-analyzer commented Jun 20, 2025

Uh oh!

bors commented Jun 20, 2025

Uh oh!

Uh oh!

Rollup of 11 pull requests #142781

Rollup of 11 pull requests #142781

Conversation

Kobzol commented Jun 20, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Kobzol commented Jun 20, 2025

Uh oh!

bors commented Jun 20, 2025

Uh oh!

bors commented Jun 20, 2025

Uh oh!

rust-log-analyzer commented Jun 20, 2025

Uh oh!

bors commented Jun 20, 2025

Uh oh!

Uh oh!

Kobzol commented Jun 20, 2025 •

edited by rustbot

Loading