Drop `./x suggest` #143630

jieyouxu · 2025-07-08T10:04:04Z

This PR removes the current ./x suggest implementation (#109933, #106249) and associated docs for several reasons:

Primarily, ./x suggest is another "flow" in bootstrap that incurs extra complexity and more invariants that bootstrap has to maintain. This causes more friction when trying to investigate and fix staging problems. As far as I know, this flow has not been actively maintained in quite a while, and I'm not aware of interest in maintaining it. Bootstrap really could use less implementation complexity with a very limited maintenance bandwidth.
The current ./x suggest implementation "bypasses" the usual stage defaults for the various check/build/test/etc. flows, and it's not really possible to have a stage default because ./x suggest --run produces a sequence of suggestions like [./x check, ./x test library/std, ..] and then tries to run all of them in sequence, based on which files are modified.
We've not seen a lot of interest both in using it or extending static/dynamic test suggestions. Last extensions were Add x suggest entries for testing mir-opt and coverage #117961 and Suggest pattern tests when modifying exhaustiveness #120763. I'm not convinced the extra implementation complexity is worth it. This was discussed in:
- #t-infra/bootstrap > Dropping the current `./x suggest` flow implementation
- #t-compiler > Dropping current `./x suggest` implementation

Closes #109933 (the current implementation is being removed).
Closes #143569 (by removing ./x suggest altogether).

rustbot · 2025-07-12T07:30:07Z

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot · 2025-07-12T07:30:09Z

triagebot.toml has been modified, there may have been changes to the review queue.

cc @davidtwco, @wesleywiser

The rustc-dev-guide subtree was changed. If this PR only touches the dev guide consider submitting a PR directly to rust-lang/rustc-dev-guide otherwise thank you for updating the dev guide with your changes.

cc @BoxyUwU, @jieyouxu, @Kobzol, @tshepang

This PR modifies src/bootstrap/src/core/config.

If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs.

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

src/bootstrap/src/utils/metrics.rs

Mark-Simulacrum · 2025-07-13T11:27:35Z

@bors r+

bors · 2025-07-13T11:27:37Z

📌 Commit 745415d has been approved by Mark-Simulacrum

It is now in the queue for this repository.

Rollup of 8 pull requests Successful merges: - #142885 (core: Add `BorrowedCursor::with_unfilled_buf`) - #143217 (Port #[link_ordinal] to the new attribute parsing infrastructure) - #143355 (wrapping shift: remove first bitmask and table) - #143448 (remote-test-client: Exit code `128 + <signal-number>` instead of `3`) - #143724 (Tidy cleanup) - #143820 (Fixed a core crate compilation failure when enabling the `optimize_for_size` feature on some targets) - #143850 (Compiletest: Simplify {Html,Json}DocCk directive handling) - #143880 (tests: Test line debuginfo for linebreaked function parameters) Failed merges: - #143630 (Drop `./x suggest`) - #143733 (Change bootstrap's `tool.TOOL_NAME.features` to work on any subcommand) r? `@ghost` `@rustbot` modify labels: rollup

jieyouxu · 2025-07-14T09:20:22Z

Rebased to fix merge conflict in change tracker, and regenerated completions.

@bors r=Mark-Simulacrum

bors · 2025-07-14T09:20:25Z

📌 Commit 8d43e6e has been approved by Mark-Simulacrum

It is now in the queue for this repository.

This is quite a bit of implementation complexity, yet it is quite broken, and we don't have the maintenance bandwidth to address. Remove the current implementation if only to reduce bootstrap's implementation complexity; the `suggest` flow comes with its own set of hacks.

jieyouxu · 2025-07-14T16:48:24Z

Rebased to fix change tracker merge conflict.

@bors r=Mark-Simulacrum

bors · 2025-07-14T16:48:26Z

📌 Commit 0a899e0 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

…lacrum Drop `./x suggest` This PR removes the current `./x suggest` implementation (rust-lang#109933, rust-lang#106249) and associated docs for several reasons: 1. Primarily, `./x suggest` is another "flow" in bootstrap that incurs extra complexity and more invariants that bootstrap has to maintain. This causes more friction when trying to investigate and fix staging problems. As far as I know, this flow has not been actively maintained in quite a while, and I'm not aware of interest in maintaining it. Bootstrap really could use less implementation complexity with a very limited maintenance bandwidth. 2. The current `./x suggest` implementation "bypasses" the usual stage defaults for the various check/build/test/etc. flows, and it's not really possible to have a stage default because `./x suggest --run` produces a *sequence* of suggestions like [`./x check`, `./x test library/std`, ..] and then tries to run all of them in sequence, based on which files are modified. 3. We've not seen a lot of interest both in using it or extending static/dynamic test suggestions. Last extensions were rust-lang#117961 and rust-lang#120763. I'm not convinced the extra implementation complexity is worth it. This was discussed in: - [#t-infra/bootstrap > Dropping the current &rust-lang#96;./x suggest&rust-lang#96; flow implementation](https://rust-lang.zulipchat.com/#narrow/channel/326414-t-infra.2Fbootstrap/topic/Dropping.20the.20current.20.60.2E.2Fx.20suggest.60.20flow.20implementation/with/527456699) - [#t-compiler > Dropping current &rust-lang#96;./x suggest&rust-lang#96; implementation](https://rust-lang.zulipchat.com/#narrow/channel/131828-t-compiler/topic/Dropping.20current.20.60.2E.2Fx.20suggest.60.20implementation/with/527528696) Closes rust-lang#109933 (the current implementation is being removed). Closes rust-lang#143569 (by removing `./x suggest` altogether).

Rollup of 16 pull requests Successful merges: - #142301 (tests: Fix duplicated-path-in-error fail with musl) - #142936 (rustdoc-json: Structured attributes) - #143355 (wrapping shift: remove first bitmask and table) - #143630 (Drop `./x suggest`) - #143738 (Move several float tests to floats/mod.rs) - #143752 (Don't panic if WASI_SDK_PATH not set when detecting compiler) - #143820 (Fixed a core crate compilation failure when enabling the `optimize_for_size` feature on some targets) - #143837 (Adjust `run_make_support::symbols` helpers) - #143878 (Port `#[pointee]` to the new attribute parsing infrastructure) - #143907 (core: make `str::split_at_unchecked()` inline) - #143910 (Add experimental `backtrace-trace-only` std feature) - #143927 (Preserve constness in trait objects up to hir ty lowering) - #143935 (rustc_type_ir/walk: move docstring to `TypeWalker` itself) - #143938 (Update books) - #143941 (update `cfg_select!` documentation) - #143948 (Update mdbook to 0.4.52) Failed merges: - #143926 (Remove deprecated fields in bootstrap) r? `@ghost` `@rustbot` modify labels: rollup

Rollup of 13 pull requests Successful merges: - #142301 (tests: Fix duplicated-path-in-error fail with musl) - #143630 (Drop `./x suggest`) - #143736 (Give all bytes of TypeId provenance) - #143752 (Don't panic if WASI_SDK_PATH not set when detecting compiler) - #143837 (Adjust `run_make_support::symbols` helpers) - #143878 (Port `#[pointee]` to the new attribute parsing infrastructure) - #143905 (Recover and suggest to use `;` to construct array type) - #143907 (core: make `str::split_at_unchecked()` inline) - #143910 (Add experimental `backtrace-trace-only` std feature) - #143927 (Preserve constness in trait objects up to hir ty lowering) - #143935 (rustc_type_ir/walk: move docstring to `TypeWalker` itself) - #143938 (Update books) - #143941 (update `cfg_select!` documentation) Failed merges: - #143926 (Remove deprecated fields in bootstrap) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #143630 - jieyouxu:drop-suggest, r=Mark-Simulacrum Drop `./x suggest` This PR removes the current `./x suggest` implementation (#109933, #106249) and associated docs for several reasons: 1. Primarily, `./x suggest` is another "flow" in bootstrap that incurs extra complexity and more invariants that bootstrap has to maintain. This causes more friction when trying to investigate and fix staging problems. As far as I know, this flow has not been actively maintained in quite a while, and I'm not aware of interest in maintaining it. Bootstrap really could use less implementation complexity with a very limited maintenance bandwidth. 2. The current `./x suggest` implementation "bypasses" the usual stage defaults for the various check/build/test/etc. flows, and it's not really possible to have a stage default because `./x suggest --run` produces a *sequence* of suggestions like [`./x check`, `./x test library/std`, ..] and then tries to run all of them in sequence, based on which files are modified. 3. We've not seen a lot of interest both in using it or extending static/dynamic test suggestions. Last extensions were #117961 and #120763. I'm not convinced the extra implementation complexity is worth it. This was discussed in: - [#t-infra/bootstrap > Dropping the current `./x suggest` flow implementation](https://rust-lang.zulipchat.com/#narrow/channel/326414-t-infra.2Fbootstrap/topic/Dropping.20the.20current.20.60.2E.2Fx.20suggest.60.20flow.20implementation/with/527456699) - [#t-compiler > Dropping current `./x suggest` implementation](https://rust-lang.zulipchat.com/#narrow/channel/131828-t-compiler/topic/Dropping.20current.20.60.2E.2Fx.20suggest.60.20implementation/with/527528696) Closes #109933 (the current implementation is being removed). Closes #143569 (by removing `./x suggest` altogether).

jieyouxu force-pushed the drop-suggest branch from e33c72d to a63824d Compare July 8, 2025 10:05

This comment has been minimized.

Sign in to view

jieyouxu force-pushed the drop-suggest branch from a63824d to cdb21d0 Compare July 8, 2025 10:28

This comment was marked as resolved.

Sign in to view

bors added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jul 10, 2025

jieyouxu force-pushed the drop-suggest branch from cdb21d0 to 9abfa8a Compare July 12, 2025 07:13

jieyouxu changed the title ~~[WIP] Drop ./x suggest~~ Drop ./x suggest Jul 12, 2025

jieyouxu marked this pull request as ready for review July 12, 2025 07:30

rustbot assigned Mark-Simulacrum Jul 12, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 12, 2025

tshepang reviewed Jul 12, 2025

View reviewed changes

src/bootstrap/src/utils/metrics.rs Outdated Show resolved Hide resolved

jieyouxu force-pushed the drop-suggest branch from 9abfa8a to 745415d Compare July 12, 2025 14:02

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 13, 2025

matthiaskrgr mentioned this pull request Jul 13, 2025

Rollup of 8 pull requests #143899

Closed

This comment was marked as resolved.

Sign in to view

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 13, 2025

jieyouxu force-pushed the drop-suggest branch from 745415d to 8d43e6e Compare July 14, 2025 09:17

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 14, 2025

This comment was marked as resolved.

Sign in to view

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 14, 2025

jieyouxu added 5 commits July 15, 2025 00:46

Register change tracker warning for removal of ./x suggest

904273c

Regenerate completions after removing ./x suggest

647c051

Remove mentions of ./x suggest and suggest-tests in rustc-dev-guide

186afbb

Update triagebot autolabel

0a899e0

jieyouxu force-pushed the drop-suggest branch from 8d43e6e to 0a899e0 Compare July 14, 2025 16:47

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 14, 2025

jhpratt mentioned this pull request Jul 15, 2025

Rollup of 16 pull requests #143951

Closed

samueltardieu mentioned this pull request Jul 15, 2025

Rollup of 13 pull requests #143958

Merged

bors merged commit f03a56f into rust-lang:master Jul 15, 2025
11 checks passed

rustbot added this to the 1.90.0 milestone Jul 15, 2025

jieyouxu deleted the drop-suggest branch July 15, 2025 14:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Drop `./x suggest` #143630

Drop `./x suggest` #143630

jieyouxu commented Jul 8, 2025 •

edited

Loading

Uh oh!

This comment has been minimized.

This comment was marked as resolved.

rustbot commented Jul 12, 2025

Uh oh!

rustbot commented Jul 12, 2025

Uh oh!

Uh oh!

Mark-Simulacrum commented Jul 13, 2025

Uh oh!

bors commented Jul 13, 2025

Uh oh!

This comment was marked as resolved.

jieyouxu commented Jul 14, 2025

Uh oh!

bors commented Jul 14, 2025

Uh oh!

This comment was marked as resolved.

jieyouxu commented Jul 14, 2025

Uh oh!

bors commented Jul 14, 2025

Uh oh!

Uh oh!

Uh oh!

Drop ./x suggest #143630

Drop ./x suggest #143630

Conversation

jieyouxu commented Jul 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

This comment was marked as resolved.

rustbot commented Jul 12, 2025

Uh oh!

rustbot commented Jul 12, 2025

Uh oh!

Uh oh!

Mark-Simulacrum commented Jul 13, 2025

Uh oh!

bors commented Jul 13, 2025

Uh oh!

This comment was marked as resolved.

jieyouxu commented Jul 14, 2025

Uh oh!

bors commented Jul 14, 2025

Uh oh!

This comment was marked as resolved.

jieyouxu commented Jul 14, 2025

Uh oh!

bors commented Jul 14, 2025

Uh oh!

Uh oh!

Uh oh!

Drop `./x suggest` #143630

Drop `./x suggest` #143630

jieyouxu commented Jul 8, 2025 •

edited

Loading