Skip to content

Remove default opts from config #145774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove default opts from config #145774

wants to merge 1 commit into from
+0 −53

Conversation

Shourya742
Copy link
Contributor

We forgot to remove this method in #145352. This PR removes that.

r? @Kobzol

@rustbot
Copy link
Collaborator

rustbot commented Aug 23, 2025

This PR modifies src/bootstrap/src/core/config.

If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Aug 23, 2025
@Kobzol
Copy link
Member

Kobzol commented Aug 23, 2025

Heh, I was thinking about it, but forgot to leave a comment. Thanks!

@Kobzol
Copy link
Member

Kobzol commented Aug 23, 2025

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Aug 23, 2025

📌 Commit b244f29 has been approved by Kobzol

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 23, 2025
samueltardieu added a commit to samueltardieu/rust that referenced this pull request Aug 23, 2025
@samueltardieu
Rollup merge of rust-lang#145774 - Shourya742:2025-08-23-remove-defau…
619cd01 
…lt-opts-method, r=Kobzol

Remove default opts from config

We forgot to remove this method in rust-lang#145352. This PR removes that.

r? `@Kobzol`
@samueltardieu samueltardieu mentioned this pull request Aug 23, 2025
Closed
bors added a commit that referenced this pull request Aug 23, 2025
@bors
Auto merge of #145785 - samueltardieu:rollup-81jw080, r=samueltardieu
b507b9e 
Rollup of 7 pull requests

Successful merges:

 - #144452 (std/sys/fd: Relax `READ_LIMIT` on Darwin)
 - #145307 (Fix `LazyLock` poison panic message)
 - #145515 (Optimize `char::encode_utf8`)
 - #145540 (interpret/allocation: get_range on ProvenanceMap)
 - #145774 (Remove default opts from config)
 - #145780 (Do not warn about missing change ID in tarball builds)
 - #145781 (Remove profile section from Clippy)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Kobzol Kobzol

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Shourya742 @rustbot @Kobzol @bors